drop python2 support, six #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping |
|
Please consider to accept this PR. |
|
funcsigs should go too... |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Sep 9, 2024
https://build.opensuse.org/request/show/1197230 by user StevenK + dimstar_suse - Switch to pyproject macros. - drop python 2 support, do not require six - added patches fix rubik/mando#57 + python-mando-no-python2.patch
|
@a-detiste Apologies for the delay. Thank you for your contribution. |
|
Thank you very much. It will take years to remove stray six usage, even in codebases that are not even Python2 compatible anymore. In comparaison python3-funcsigs was removed pretty fast from Debian, like a two weeks job. I will provide a second PR, or you can apply this patch (it was needed as a workaround in the bug in the release tooling, not even in Mando itself, but as it was the last user of funcsigs it was the most practical thing to do): |
|
Thank you Alexandre! I'll apply that patch and release another minor version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.