Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webpack to v5 #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pfftdammitchris
Copy link

I upgraded these dependencies in order to support webpack 5:

  • webpack 4 --> 5
  • webpack-cli 3 --> 4
  • copy-webpack-plugin 4 --> 8

I applied updates from breaking changes from migrating webpack 4 to webpack 5 in this pull request:

  • compilation.chunks changed from Chunk[] to Set<Chunk>
  • chunk.files changed from string[] to Set<string>
  • webpack.config.js syntax in module.rules to change plural loaders to loader, and use for multiple loaders
  • Updates to some typescript typings

I also changed the middleware.raw.ts raw source file to bind itself to window if it exists (because I was getting errors that browser stayed null:

image

@tmhrbr
Copy link

tmhrbr commented Nov 16, 2021

Can we get one merged please?

@w3sheldon w3sheldon mentioned this pull request Dec 30, 2021
6 tasks
@dvdvdmt
Copy link

dvdvdmt commented Jan 2, 2022

@rubenspgcavalcante please accept this PR 🙏

@rushilsrivastava
Copy link

rushilsrivastava commented Jan 24, 2022

Hi all, please check out https://github.com/SimplifyJobs/webpack-ext-reloader/. We are maintaining the webpack 5 version + rolling out manifest v3 soon! PRs welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants