Conditional dependency to module 'enum34': Ony for python_version < "3.4.0" #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-koeller
changed the title
michael-koeller
changed the title
|
If I understand that bug report correctly this only occurs with a Please rebase on master, than I will merge. |
michael-koeller
force-pushed
the
issue/enum34
branch
from
d6afb6f
to
a6f395f
Compare
|
Done.
… Am 08.03.2021 um 12:18 schrieb Marcel Röthke ***@***.***>:
If I understand that bug report correctly this only occurs with a pyproject.toml, but we still use a setup.py.
And I never encountered this even though I develop on archlinux.
Probably makes sense to have this anyway.
Please rebase on master, than I will merge.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#16 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALKVDKQKYINJNSAMFICXWLTCSW7XANCNFSM4YMSGPDQ>.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current master of rtrlib/python-binding may cause pip installations to fail on Python versions 3.6 - 3.8 because of the dependency to module enum34. This dependency is not needed for Python 3.4 and above.
This is a known issue with pip and seems to be fixed only recently (2020-12).
Since e.g. default Python version on Ubuntu 20.04 LTS is 3.8, where the issue will still be present, I think this project should guard against pip installation fails by adding a version contition to the dependency.