Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default comment to name attribute #63

Merged
merged 1 commit into from
Feb 5, 2015

Conversation

dblessing
Copy link
Contributor

By default, set the comment for a rule to the resource name. This enables simple rule creation with nice comments. Of course, if a user wants to they can still set an arbitrary resource name and specify a comment separately.

Instead of:

simple_iptables_rule 'some arbitrary thing' do
  comment 'accept all on loopback interface'
  chain 'INPUT'
  rule '--in-interface lo'
  jump 'ACCEPT'
  weight 1
end

We can now do this:

simple_iptables_rule 'accept all on loopback interface' do
  chain 'INPUT'
  rule '--in-interface lo'
  jump 'ACCEPT'
  weight 1
end

rtkrruvinskiy added a commit that referenced this pull request Feb 5, 2015
@rtkrruvinskiy rtkrruvinskiy merged commit b483d6b into rtkwlf:master Feb 5, 2015
@rtkrruvinskiy
Copy link
Contributor

@dblessing Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants