This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5599c4f:
|
size-limit report 📦
|
msutkowski
commented
Mar 18, 2021
Move arg into the hook call site. |
msutkowski
force-pushed
the
lazy-query
branch
4 times, most recently
from
March 20, 2021 22:16
5692070
to
b097568
Compare
|
phryneas
reviewed
Mar 21, 2021
msutkowski
force-pushed
the
lazy-query
branch
2 times, most recently
from
March 21, 2021 17:16
bd9822a
to
57a2bee
Compare
msutkowski
commented
Mar 21, 2021
3 tasks
phryneas
reviewed
Mar 21, 2021
msutkowski
force-pushed
the
lazy-query
branch
8 times, most recently
from
March 22, 2021 01:03
25d1a65
to
4771d0a
Compare
Okay, remaining issues with this:
|
msutkowski
force-pushed
the
lazy-query
branch
2 times, most recently
from
March 25, 2021 17:00
07cfc1e
to
7176c0b
Compare
msutkowski
commented
Mar 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. I agree with everyone who says hooks can be hard :)
Co-authored-by: Lenz Weber <[email protected]>
Co-authored-by: Lenz Weber <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
useLazyQuery
, which allows users to opt-in to calling a query with arguments.Once a request is made, the query will stay subscribed to any changes while mounted in the scenario that there are other components mounted with the same query. If the arg that
fetchThing
is called with changes, it will perform a new request and then behave the same way. Additionally, we always unsubscribe an existing query before initiating a new one when thetrigger
is called.[insert visual reference :D]