This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
remove internalQueryArgs #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Args, rename endpoint to endpointName or endpointDefinition everywhere
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 68bfbeb:
|
msutkowski
suggested changes
Jan 24, 2021
Co-authored-by: Matt Sutkowski <[email protected]>
|
Same 😅 |
msutkowski
approved these changes
Jan 24, 2021
|
@phryneas We do confirm that it solves our problem 👍 : https://codesandbox.io/s/rtk-query-demo-forked-hd08r?file=/src/app/services/posts.ts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would address #154 and #155 in a more broad manner.
Also, I added
endpointDefinitiontoserializeQueryArgsand renamedendpointtoendpointDefinitionorendpointNameeverywhere to be more consistent.Hope I didn't change a public API with it 😅 (apart from
serializeQueryArgs)@msutkowski could you take a look at this? Also, @gfortaine, can you please test if this would solve your problem?