Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

Smarter handling optional parameters #146

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Smarter handling optional parameters #146

merged 2 commits into from
Jan 12, 2021

Conversation

kahirokunn
Copy link
Contributor 

console.log(new URLSearchParams({ a: 'helloworld', b: undefined }).toString())
"a=helloworld&b=undefined"

This b=undefined should be unintentional, so undefined should be removed.

@kahirokunn
console.log(new URLSearchParams({ a: 'helloworld', b: undefined }).to…
13118c8 
…String())

"a=helloworld&b=undefined"

This b=undefined should be unintentional, so undefined should be removed
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 12, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8d6e1c9:

Sandbox Source
React Configuration
React Typescript Configuration
rtk-query-demo Configuration
svelte-app-rtk-simplequery-demo Configuration

@msutkowski msutkowski mentioned this pull request Jan 12, 2021
Closed
@msutkowski msutkowski merged commit 01accd6 into rtk-incubator:next Jan 12, 2021
@msutkowski
Copy link
Member

Thanks again @kahirokunn !!!!!!!

@kahirokunn
Copy link
Contributor Author

Thank you too!!!

@phryneas phryneas mentioned this pull request Mar 6, 2021
Closed
@phryneas phryneas mentioned this pull request Apr 18, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phryneas phryneas phryneas approved these changes

@msutkowski msutkowski msutkowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kahirokunn @msutkowski @phryneas