feat: binary hook engine with lexer, streaming, and rewrite_compound integration

[ahundt]

Summary

This PR #536 integrates the hooks-v2 engine (from PR #156) with the develop branch (note that #537 is the same code as 536 and 156 but it is stripped of tests for easier reviewing), and #361 describes the bug fixes in this pr, this pr #536 demonstrates that:

1. The lexer is a drop-in replacement for rewrite_compound()'s inline byte scanner — all 155 existing rewrite tests pass unchanged
2. The binary hook path (rtk hook claude) works alongside the shell hook path (rtk rewrite)
3. The streaming infrastructure (stream.rs) enables bidirectional process shims with exit code transparency

Key components

• src/cmd/lexer.rs — Shell-aware tokenizer (56 tests): handles quoting, escapes, $(), backticks, globs, redirects, 2>&1
• src/cmd/analysis.rs — Command chain parser (61+ tests): needs_shell() detection, parse_chain() for &&/||/; chains
• src/cmd/hook/mod.rs — Binary hook engine (98 tests): conservative hook_lookup() whitelist, Claude Code JSON protocol, safe suffix handling
• src/cmd/exec.rs — Native command executor: runs simple chains natively, delegates complex shell to /bin/sh
• src/stream.rs — Streaming process execution (39 tests): StreamFilter trait, StdinMode::Inherit for pipe support, SIGPIPE handling, 1 MiB raw cap
• src/pipe_cmd.rs — rtk pipe --filter dispatch for grep/rg/find/fd output filtering
• src/discover/registry.rs — rewrite_compound() replaced: lexer-based splitting instead of 130-line inline byte scanner

Lexer integration in rewrite_compound()

The byte-level quote tracker in rewrite_compound() (~130 lines) is replaced with lexer::tokenize() calls (~80 lines). The lexer adds:

• Escape sequence handling (\\)
• $() and backtick detection (Shellism tokens)
• Glob detection (*, ? → Shellism)
• Redirect parsing — not confused with && operator (2>&1, &>/dev/null)

Token byte offsets (ParsedToken.offset) enable extracting original substrings from the command string, so rewrite_segment() receives exact original text — no reconstruction fidelity issues.

Binary hook architecture

Two complementary routing paths:

• Shell hook: rtk rewrite → registry::rewrite_command() → rewrite_compound() → rewrite_segment() (TOML filters + RULES table)
• Binary hook: rtk hook claude → check_for_hook() → lexer::tokenize() → analysis::parse_chain() → hook_lookup() → route_native_command() (conservative whitelist)

The binary hook uses a strict whitelist (hook_lookup()) that only routes subcommands RTK optimizes well (e.g., git status but not git rebase, cargo test but not cargo publish).

Init system (src/init.rs)

• --hook-type binary|script flag to select hook mode
• Plugin cache patching: removes Bash from plugin matchers, writes manifest
• Manifest-based handler dispatch for both NoOpinion and Allow paths
• backup_file_once() + atomic_write() for safe file operations
• OpenCode plugin support (develop's --install-opencode flag preserved)

Test plan

• cargo test — 1309 passed, 0 failed, 6 ignored
• cargo fmt --all — clean
• cargo clippy --all-targets — clean
• All 155 registry rewrite tests pass (including develop's TOML rule tests)
• All 56 lexer tests pass
• All 98 hook tests pass
• All 39 streaming tests pass
• Manual: rtk rewrite "cargo test && git status" produces rtk cargo test && rtk git status
• Manual: rtk rewrite "cargo test | grep FAIL" produces rtk cargo test | grep FAIL
• Manual: rtk rewrite "cargo test 2>&1" produces rtk cargo test 2>&1

Stats

46 files changed, ~9500 insertions, ~450 deletions

Fixes #222

[ahundt]

I updated again to match upstream, it is ready to merge to the best of my knowledge! Additionally this pr fixes the multi-hook conflict bug that is now independently confirmed by #361 (comment)

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ ousamabenyounes
✅ pszymkowiak
✅ FlorianBruniaux
❌ ahundt
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 4 committers have signed the CLA.

❌ ahundt
❌ pszymkowiak
❌ ousamabenyounes
❌ FlorianBruniaux
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[ahundt]

i signed the cla, but note all the other names listed are from contributions already merged in the repository

[KuSh]

i signed the cla, but note all the other names listed are from contributions already merged in the repository

Using rebase instead of merge should fix that

[aeppling]

Hey

We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes src/ from a flat layout into subfolders.

No logic changes — only file moves and import path updates.

What you need to do

Rebase your branch on develop when receiving this comment:

git fetch origin && git rebase origin/develop

Git detects renames automatically. If you get import conflicts, update the paths:

use crate::git;        // now: use crate::cmds::git::git;
use crate::tracking;   // now: use crate::core::tracking;
use crate::config;     // now: use crate::core::config;
use crate::init;       // now: use crate::hooks::init;
use crate::gain;       // now: use crate::analytics::gain;

Need help rebasing? Tag @aeppling

[aeppling]

Hello @ahundt

First we're sorry about the delays, RTK has grown quicker than ever in the last 2 month, and being only 3 maintainers (with each having their jobs), it was hard for us to catch on everything.

We are currently organizing many aspect of this project, including codebase, contributions, and so on....

All this so RTK can keep growing and scale.

This include also a refacto of some part of the codebase.

This PR include some very good ideas, but that will need to be implemented as part of the refactoring.
If you're interested i'll mention you, if you want we can even discuss together in discord server about the routing refactoring, streaming etc..

Again, sorry for the time to answer you, but i prefer to rush any core features or update, but i did not forget this PR.

I'll be back to you soonly, once i've completed the first parts of my refactoring plan, so i can implement your ideas in the refactoring plan.

Thanks Andrew !

[aeppling]

Hey, all ideas have been implement in the codebase during 0.36 and 0.37 releases , closing this.

If any request , please reach me on Discord

Thanks again Andrew !

[ahundt]

@aeppling unfortunately, while I very much appreciate what has been implemented, that is not correct, they were not implemented, and some of the core bugs remain to the best of my knowledge. This is the actual important branch with the fixes iirc.

[KuSh]

@ahundt would you be able to summarize what's still missing and or buggy in rtk 0.37+?