Skip to content

fix(cargo): preserve complete failure diagnostics #4643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pocketman70651 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(cargo): preserve complete failure diagnostics #4643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/cmds/rust/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,9 @@
- `cargo_cmd.rs` uses `restore_double_dash()` fix: Clap strips `--` but cargo needs it for test flags (e.g., `cargo test -- --nocapture`)
- `runner.rs` is a generic two-mode runner (`err` = stderr only, `test` = failures only) used as fallback for commands without a dedicated filter. It executes argv directly by default; `--shell <name> '<script>'` is the explicit escape hatch for shell syntax.
- `runner.rs` is also referenced by other modules outside this directory as a generic command executor

## Cargo diagnostics

`cargo build`, `cargo check`, and `cargo test` stream unmatched text directly, including complete panic backtraces, compiler explanations, and rerun hints. Successful test summaries and compilation progress are still compressed. Once a text diagnostic starts, subsequent lines are retained so diagnostic text cannot be mistaken for progress.

JSON build/check/clippy output renders every compiler diagnostic without error or warning count caps. Records without rendered text retain their original JSON so spans and child diagnostics remain available. This intentionally favors diagnostic completeness over fixed-size failure output; JSON envelopes and artifact records still provide compression. The existing batch JSON/clippy runner combines output streams; text build/check/test preserve diagnostic streams.
Loading