Repository navigation
fix: resolve #4300 MinimalFilter keeps a dead Python docstring bran... - #4301
Draft
chenzeyan54-commits wants to merge 1 commit into
Draft
chenzeyan54-commits wants to merge 1 commit into
chenzeyan54-commits wants to merge 1 commit into
Conversation
…after the Python early return Since rtk-ai#3336, `MinimalFilter::filter` returns early for Python at `src/core/filter.rs:280` (`filter_python_minimal`). The generic loop below still carr... Signed-off-by: chenzeyan54-commits <chenzeyan54-commits@users.noreply.github.com>
|
|
📊 Automated PR Analysis
SummaryRemoves a dead code branch in MinimalFilter that separately tracked Python docstring state, since #3336 already made filter_python_minimal handle Python early and the generic loop's docstring logic was unreachable/redundant. Adds several new tests covering multi-line, single-line, and consecutive Python docstring cases. Review Checklist
Linked issues: #4300 Analyzed automatically by wshm · This is an automated analysis, not a human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixes #4300
Overview
Since #3336,
MinimalFilter::filterreturns early for Python atsrc/core/filter.rs:280(filter_python_minimal). The generic loop below still carr...Key Changes
Verification