Repository navigation
[feat] Add shim to make rtk work with Codex - #424
sunxiaoguang wants to merge 4 commits into
Conversation
RTK is great, I really want to use it with Codex as well. Unfortunately, Codex does not have a PreToolUse hook. This commit implements a shim to override supported tools within a customized directory in the PATH to make it work with Codex. Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
|
Hi ! would you accept including your work in #377 , or vice versa |
Sure, let's get it pushed to repo so everybody can benefit from this. |
|
Hi! Thanks for the contribution! Since March 6, all PRs should target the Could you update the base branch? Click Edit at the top right of this PR and change it from Thanks! |
|
Thanks for the contribution! The shim approach is interesting but we're going with a lighter AGENTS.md-based approach in PR #377 for now. The shim system would also need an uninstall command and scoping to Codex sessions only (currently affects all shells). Feel free to iterate on it as a separate proposal if you'd like! |
|
I put together an implementation in #642 to validate the shim-based Codex path end-to-end. What I implemented:
Technical details:
This also addresses the two concerns raised on the shim PR:
While I think AGENTS.md would do the work, the fact that AGENTS.md is still prompt would make the integration depend on prompt/instruction behavior rather than execution-layer behavior. Therefore I believe shim might be necessary. |
|
|
|
Thanks for the contribution! This feature has already been integrated in the latest version (v0.33.1). Please verify with the latest release that everything works as expected on your side. Closing as already included — thanks! |
|
Hey We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes No logic changes — only file moves and import path updates. What you need to doRebase your branch on git fetch origin && git rebase origin/developGit detects renames automatically. If you get import conflicts, update the paths: use crate::git; // now: use crate::cmds::git::git;
use crate::tracking; // now: use crate::core::tracking;
use crate::config; // now: use crate::core::config;
use crate::init; // now: use crate::hooks::init;
use crate::gain; // now: use crate::analytics::gain;Need help rebasing? Tag @aeppling |
|
Thanks for this @sunxiaoguang! Codex support has since landed in RTK — |
RTK is really great, I want to use it with Codex as well. Unfortunately, Codex does not have a PreToolUse hook. This PR implements a shim to override supported tools within a customized directory in the PATH to make it work with Codex.
Closes: #425