Skip to content

fix(pytest): preserve collection-only summaries #4192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ha1baraA11 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(pytest): preserve collection-only summaries #4192

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49ba389
fix(pytest): preserve collection-only summaries
Ha1baraA11 Sep 22, 2026
c76ebd0
Merge develop and fix pytest collection summaries
Ha1baraA11 Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions src/cmds/python/pytest_cmd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ pub(crate) fn filter_pytest_output(output: &str) -> String {
} else if trimmed.starts_with("===")
&& (trimmed.contains("passed")
|| trimmed.contains("failed")
|| trimmed.contains("skipped"))
|| trimmed.contains("skipped")
|| trimmed.contains("collected"))
{
summary_line = trimmed.to_string();
continue;
Expand All @@ -112,9 +113,10 @@ pub(crate) fn filter_pytest_output(output: &str) -> String {
&& !trimmed.starts_with("===")
&& !trimmed.starts_with("FAILED")
&& !trimmed.starts_with("ERROR")
&& (trimmed.contains(" passed")
&& ((trimmed.contains(" passed")
|| trimmed.contains(" failed")
|| trimmed.contains(" skipped"))
|| trimmed.contains(" collected"))
&& trimmed.contains(" in ")
{
summary_line = trimmed.to_string();
Expand Down Expand Up @@ -177,6 +179,7 @@ struct PytestCounts {
skipped: usize,
xfailed: usize,
xpassed: usize,
collected: usize,
}

fn build_pytest_summary(
Expand All @@ -192,9 +195,13 @@ fn build_pytest_summary(
skipped,
xfailed,
xpassed,
collected,
} = counts;

if passed == 0 && failed == 0 && skipped == 0 && xfailed == 0 && xpassed == 0 {
if collected > 0 {
return format!("Pytest: {collected} tests collected");
}
return PYTEST_NO_TESTS.to_string();
}

Expand Down Expand Up @@ -308,6 +315,12 @@ fn parse_summary_line(summary: &str) -> PytestCounts {
for part in summary.split(',') {
let words: Vec<&str> = part.split_whitespace().collect();
for (i, word) in words.iter().enumerate() {
if *word == "collected" && i >= 2 {
if let Ok(n) = words[i - 2].parse::<usize>() {
counts.collected = n;
}
continue;
}
if i == 0 {
continue;
}
Expand Down Expand Up @@ -415,6 +428,17 @@ collected 0 items
assert!(result.contains("No tests collected"));
}

#[test]
fn test_filter_pytest_collect_only_reports_collected_count() {
let output = r#"tests/test_foo.py::test_one
tests/test_foo.py::test_two

========================= 15 tests collected in 0.17s =========================="#;

let result = filter_pytest_output(output);
assert_eq!(result, "Pytest: 15 tests collected");
}

#[test]
fn test_parse_summary_line() {
let c = parse_summary_line("=== 5 passed in 0.50s ===");
Expand Down