Skip to content

fix: trigger release build after release-please creates tag - #40

Merged
pszymkowiak merged 1 commit into
rtk-ai:masterfrom
FlorianBruniaux:fix/release-workflow-trigger
Feb 2, 2026
Merged

pszymkowiak merged 1 commit into
rtk-ai:masterfrom
FlorianBruniaux:fix/release-workflow-trigger

Conversation

@FlorianBruniaux

Copy link
Copy Markdown
Contributor

Summary

Fixes #27

Tags created by GITHUB_TOKEN don't trigger other workflows. This PR makes release-please.yml call release.yml directly via workflow_call after creating a release.

Changes

release.yml

  • Add workflow_call trigger with tag input
  • Handle workflow_call in version detection logic
  • Upload assets for both release and workflow_call events

release-please.yml

  • Add build-release job that calls release.yml with the tag
  • update-latest-tag now waits for build to complete before updating

Why this approach?

Approach Pros Cons
PAT token Simple Requires secret management, security risk
workflow_call ✅ No secrets, clean, maintainable Minor changes to both files
Merge workflows Single file Complex, harder to maintain

Flow after this PR

push to master
  → release-please creates tag + GitHub Release
  → build-release job calls release.yml
  → binaries built and uploaded to release
  → update-latest-tag updates the 'latest' tag

Test Plan

  • Merge a release PR
  • Verify release.yml is triggered via workflow_call
  • Verify binaries are uploaded to the GitHub Release
  • Verify latest tag is updated after build completes

🤖 Generated with Claude Code

Fixes rtk-ai#27

Tags created by GITHUB_TOKEN don't trigger other workflows. This change
makes release-please call release.yml directly via workflow_call after
creating a release.

Changes:
- release.yml: Add workflow_call trigger with tag input
- release.yml: Handle workflow_call in version detection
- release.yml: Upload assets for workflow_call events
- release-please.yml: Add build-release job that calls release.yml
- release-please.yml: update-latest-tag now waits for build to complete

This approach:
- Requires no PAT/secrets
- Keeps workflows separate and maintainable
- Uses workflow_call (cleaner than workflow_dispatch)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings February 1, 2026 20:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #27 where tags created by release-please don't trigger the release build pipeline. The solution uses workflow_call to directly invoke release.yml from release-please.yml after a release is created, avoiding the limitation that tags created by GITHUB_TOKEN don't trigger other workflows.

Changes:

  • Added workflow_call trigger to release.yml with tag input parameter
  • Updated version detection logic to handle workflow_call events
  • Modified asset upload condition to include workflow_call events
  • Added build-release job in release-please.yml that calls release.yml
  • Updated update-latest-tag job to wait for build completion

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/release.yml Added workflow_call trigger with tag input, updated version detection logic to handle workflow_call events, and modified asset upload condition to support workflow_call
.github/workflows/release-please.yml Added build-release job that calls release.yml via workflow_call, and updated update-latest-tag to depend on build completion

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +6 to +11
workflow_call:
inputs:
tag:
description: 'Tag to release'
required: true
type: string

Copilot AI Feb 1, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow_call trigger is defined correctly, but the implementation is incomplete. When this workflow is called via workflow_call, the checkout actions throughout the workflow (at lines 54, 96, 119, and 146) will default to checking out the branch that triggered the caller workflow (master), not the tag that was just created.

All checkout actions need to add a ref parameter that uses the tag input when workflow_call is the event type. For example:

- name: Checkout
  uses: actions/checkout@v4
  with:
    ref: refs/tags/${{ inputs.tag }}

Note: You'll need to make the ref conditional based on the event type, or use a default that works for all cases.

Copilot uses AI. Check for mistakes.
@pszymkowiak
pszymkowiak merged commit 3ddffdd into rtk-ai:master Feb 2, 2026
6 of 7 checks passed
ahundt pushed a commit to ahundt/rtk that referenced this pull request Feb 23, 2026
…w-trigger

fix: trigger release build after release-please creates tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: release-please tag does not trigger release build pipeline

3 participants