Repository navigation
fix(benchmark): skip find's disclosure note and tee pointer when counting names - #3863
Merged
Merged
Conversation
…ting names count_find_names and count_find_total treat every unrecognised line as a row of names. Since find began reporting hidden and gitignored matches, its output ends with `... (N filtered)` and a `[see remaining: ...]` pointer, so `rtk find '*' --max 10` counted 19 names (10 + 3 + 6 words) and the --max cap check failed. Skip both lines, as the header, `+N more` and `ext:` lines already are.
pszymkowiak
approved these changes
Sep 4, 2026
Merged
This was referenced Sep 6, 2026
Merged
kylehgc
added a commit
to kylehgc/rtk
that referenced
this pull request
Sep 6, 2026
…t half The benchmark find-count half (a990b99) is superseded by d952a6b (rtk-ai#3863), which skips the same disclosure-note and tee-pointer lines; scripts/benchmark.sh is upstream's again. What remains is the single ci.yml line: `cargo install cargo-audit --locked`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
--maxcap check counts every unrecognised line as names.findnow ends its output with... (N filtered)and a[see remaining: …]pointer (#3854), sortk find '*' --max 10counted 19 and the job went red.Changes
Two
nextrules incount_find_names/count_find_total.Test
./scripts/benchmark.sh:find --max 10 cap10/410,find --max 100 cap100/410.