Repository navigation
fix: use line.len() - pos fallback in prisma migration slice - #3502
Closed
mmustafasenoglu wants to merge 1 commit into
Closed
mmustafasenoglu wants to merge 1 commit into
mmustafasenoglu wants to merge 1 commit into
Conversation
Line 252 already uses .unwrap_or(line.len() - pos) for the same pattern. Line 319 had .unwrap_or(20) which panics when the token is shorter than 20 bytes and sits at end-of-line with no trailing whitespace. Closes #3445
|
|
Collaborator
|
Closing in favour of #3836, which applies the identical line.len() - pos fallback and adds the regression test that filter_migrate_status was missing, covering both the end of line id and the multibyte case. Review and comments are welcome there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3445
Line 319 uses
.unwrap_or(20)as the fallback when no whitespace is found after the migration token. If the token is shorter than 20 bytes and at end-of-line, this causes an out-of-bounds slice panic.Line 252 in the same file already has the correct fallback:
.unwrap_or(line.len() - pos). This PR applies the same fix to line 319.