Repository navigation
fix(git): preserve patch output from log commands - #2951
Conversation
Adopt upstream rtk-ai#2951 into kylehgc/rtk. Closes #33
|
Built this branch and ran the #2944 repro against it — it does what it claims. With a 300-line diff and the secret at ~line 152 of the hunk:
So this closes the One note on the test in this PR, meant to help rather than block: (Verified on Windows / |
requests_raw_log_output() scanned the full args slice for patch flags like -p, so `git log -- -p` (a literal pathspec named -p) was misdetected as a raw patch request and skipped RTK's normal filtering. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
KuSh
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your contribution
rtk 0.46.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## [0.46.0](rtk-ai/rtk@v0.45.0...v0.46.0) (2026-08-26) ### Features - find: dispatch on find's grammar; compress find output for unmodeled predicates ([#3603](rtk-ai/rtk#3603)) - find: tee tail hint when rtk imposes the result cap ([#3603](rtk-ai/rtk#3603)) ### Bug Fixes - find: never-worse guard, recovery hint, and dispatch on find's grammar ([#3603](rtk-ai/rtk#3603)) - git: don't misdetect a value-taking option's argument as a patch flag ([#3575](rtk-ai/rtk#3575)) - cicd: stop benchmark.sh deleting the tracked scripts/benchmark harness ([#3595](rtk-ai/rtk#3595)) - tee: hash long recovery-file slugs to prevent collisions and shorten hints ([#3266](rtk-ai/rtk#3266)) - benchmark: avoid negative curl/cargo cases that fail the benchmark job ([#3430](rtk-ai/rtk#3430)) - test: accept both Ask and Allow verdicts in rewrite tests ([#3147](rtk-ai/rtk#3147)) — Closes [#3146](rtk-ai/rtk#3146) - core: decode process output using Windows console code page ([#2717](rtk-ai/rtk#2717)) — Closes [#2452](rtk-ai/rtk#2452) - git: preserve patch output from log commands ([#2951](rtk-ai/rtk#2951)) — Closes [#2944](rtk-ai/rtk#2944) - discover: sanitize drive-letter colon so Windows discover finds sessions ([#2952](rtk-ai/rtk#2952)) — Closes [#2919](rtk-ai/rtk#2919) - stream: decode lossily instead of dropping lines on invalid UTF-8 ([#2997](rtk-ai/rtk#2997)) — Closes [#2994](rtk-ai/rtk#2994) ### Other - test(find): use the platform temp dir instead of /tmp ([#3717](https://github.com/rtk-ai/rtk/pull/3717))</pre> <p>View the full release notes at <a href="https://github.com/rtk-ai/rtk/releases/tag/v0.46.0">https://github.com/rtk-ai/rtk/releases/tag/v0.46.0</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!17826
Summary
-p,-u,--patch,--patch-with-raw, and--patch-with-statas explicit requests for rawgit logoutputCloses #2944.
Testing
cargo fmt --all -- --checkcargo clippy --all-targets -- -D warningscargo test --all(2,496 passed; 8 ignored)rtk git log -p --allbyte-matches raw Git and preserves a searched test-key markerAI-assisted contribution.