Repository navigation
Conversation
5 tasks
4 of 5 tasks
Collaborator
|
Closing this as a duplicate of #2931, which makes the same project-directory match case-insensitive but keeps it to Windows via cfg!(windows), so Unix matching is unchanged, and which merges cleanly against develop. The colon half of this PR already landed on develop through #2952. Please take a look at #2931 and comment there, or reply here if you think the unconditional match was deliberate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk discovercurrent-project matching when Claude Code stores project slugs with a different drive-letter/path case.:with-, matching the reported Claude Codee--...project directory shape.E:\...cwd input matching a lowercasee--...Claude project directory.Fixes #2919
Test plan
cargo fmt --all --checkcargo clippy --all-targetscargo testcargo test discover::provider::tests::test_encode_project_path_windowscargo test discover::provider::tests::test_discover_sessions_matches_windows_project_filter_case_insensitivelyI could not manually reproduce on Windows from this Linux environment; the regression test simulates the reported project-directory casing/slug mismatch.