Repository navigation
Conversation
Contributor
|
Automatic message from CI checks : It seems like this branch is targeting the wrong branch, any contribution should target develop branch. See CONTRIBUTING.md for details. |
Contributor
Author
|
Closing because this was opened against master before checking the existing CodeBuddy issue/PR context. I will rebuild the WorkBuddy change on top of develop and avoid duplicating #1967. |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk init --workbuddyandrtk hook workbuddy.Why
WorkBuddy can call a Claude-compatible
PreToolUsehook and usesexecute_commandin IDE mode, but RTK did not have a dedicated setup or hook command for it.Changes
updatedInputandmodifiedInput..workbuddy/settings.jsonor~/.workbuddy/settings.jsonwith matcherBash|execute_command.Review Guide
This is intended to stack after #2065 because both integrations share the Claude-compatible hook response helper. GitHub cannot base an upstream PR on a fork-only branch, so this PR temporarily targets
masterand includes the earlier CodeBuddy commit until #2065 lands. Start withsrc/main.rsfor the new CLI and hook entry points, then reviewsrc/hooks/init.rsfor the WorkBuddy settings writer.Verification
rtk cargo test workbuddyrtk cargo test codebuddyrtk cargo fmt --all --checkrtk cargo clippy --all-targets(exited successfully; existing warnings remain in unrelated dotnet/go/js filter files)rtk cargo test --all(1753 passed, 6 ignored)Risk
Risk level: Low
Potential impact: Incorrect WorkBuddy settings could make the integration fail to rewrite commands, but the change is opt-in through
rtk init --workbuddy.Rollback plan: Revert this PR to remove the WorkBuddy CLI path, hook adapter, and settings writer.