Repository navigation
fix(tee): safe truncation caps and tee/hint coverage - #1928
Merged
Merged
Conversation
Replace all bare magic offset literals (e.g. 21 for cap=20) with named constants (MAX_XXX + 1) so offsets stay in sync if caps change. Fix compose_ps to tee pre-formatted lines instead of raw tab-separated input, so tail -n +N gives the agent readable content. All 13 affected modules updated: container, dotnet, gh, glab, go, lint, pnpm, pytest, rubocop, cargo, aws. 1884 tests pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
aeppling
force-pushed
the
fix/tee-hint-trunc-quality
branch
from
May 19, 2026 08:29
30a05ae to
4acdcf2
Compare
pszymkowiak
approved these changes
May 19, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
important
Merge #1895 first
Summary
Every RTK filter that truncates output must give the agent a way to recover the hidden content. Before this PR, many truncation sites showed "… +N more" with no recovery path, and some that did have tee hints used bare magic offsets that would silently diverge if the cap changed.
This PR addresses two things:
1. Full tee/hint coverage : All truncation sites now emit either:
2. Safe caps via named constants :
Bugs fixed