-
Notifications
You must be signed in to change notification settings - Fork 82
Moving to async/await: lib/Runner.js #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 5 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
23629ec
elm-test.js: Organize `require`s
lydell 6f1612f
elm-test.js: Remove dead code
lydell c13377b
elm-test.js: Remove unnecessary uncaughtException handler
lydell e4cdcd5
elm-test.js: Replace `var` with `let` and `const`
lydell e3bd626
elm-test.js: Use arrow functions
lydell ba9d21d
elm-test.js: Remove unused CLI flag
lydell 5419e73
elm-test.js: WIP Parse CLI arguments in a more structured way
lydell 6572e92
Remove undocumented and rather useless --verbose option
lydell 469482e
Hide compiler Success print
lydell c7cb303
Fix option parsing
lydell ed0f4bf
Moving to async/await: lib/Runner.js
chebro 16bbbe6
Moving to async/await: lib/elm-test.js
chebro 27e8b58
Moving to async/await: lib/elm-test.js - Forgot to pass error to catc…
chebro e7968cc
Moving to async/await: lib/Runner.js - added await keyword
chebro 0963716
Moving to async/await: lib/Runner.js - fixed async on the wrong function
chebro 7f52eba
shifted function calls inside try blocks
chebro 10e60b7
Parse --flag=value
lydell 937827b
Tests
lydell d735086
Add some type annotations
lydell 3dd8c8a
Remove unnecessary globifyWithRoot function
lydell 62081dc
Type Report
lydell 9ae34c7
Use type for Report everyhere
lydell 8e83f1f
Don’t require elm to exist in PATH to be able to show help
lydell b30f848
Improve help text
lydell 53e68a1
Improve error messages
lydell 7bd27a7
Convert to async/await where it improves readability
lydell d56ef96
Reorder functions slightly for better readability
lydell 8b56a06
Various cleanups
lydell df6d286
Better description for --compiler
lydell 322b832
Show defaults for all options
lydell d3c3ade
Fix accidentally flipped condition
lydell dda50af
Better data field for Error
lydell ab65696
Move flags parsing to its own file
lydell 1c45531
Reorder and better parameter name
lydell 02aa8c2
Exhaustive check switch:es in elm-test.js
lydell 263f671
Add some more type annotations
lydell bc3599a
Test negative integers
lydell 9199b63
Comment Prettier/Flow shenanigans
lydell 77110d0
Remove defunct Node.js version check
lydell 814e814
Disallow `--watch=some-value`
lydell ef5b05b
Merge lydell:improve-elm-test.js -> chebro:async-await
chebro 34033e2
Merge pull request #1 from lydell/improve-elm-test.js
chebro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.