Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fsevents and chokidar #264

Merged
merged 3 commits into from
Sep 2, 2018
Merged

Conversation

m-shaka
Copy link
Contributor

@m-shaka m-shaka commented Aug 13, 2018

Hi. When using elm-test with node v10, this error occurs.

To fix this, I updated some dependencies.

@rtfeldman
Copy link
Owner

@m-shaka Can you rebase on current master and pin the dependencies to exact versions? (no ^ in them, that is.)

Thanks for this!

@halfzebra
Copy link

halfzebra commented Sep 2, 2018

@m-shaka good stuff! 👍

@rtfeldman what do you think of removing package-lock.json and setting fsevents and chokidar versions to "latest minor version"? I do not suggest that this is applicable to all the packages, but those two are fairly reliable in terms of semver.

@rtfeldman rtfeldman merged commit 5bc10b2 into rtfeldman:master Sep 2, 2018
@rtfeldman
Copy link
Owner

Thanks @m-shaka!

@halfzebra for applications I always like to pin dependencies exactly, so if two teammates install the same version they're always getting the same thing. Cuts down on "I can't reproduce; maybe uninstall and reinstall?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants