Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send the parsed stringified JSON to Elm in localStorate event listener #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rlopzc
Copy link

@rlopzc rlopzc commented Sep 24, 2019

The event.newValue contains the stringified version of the store. In order to send the same value as in line 38, we need to parse it before sending it.

In my case, I was updating the token of the session in multiple tabs. It was incorrectly sending the new Viewer to each tab. The session was getting deleted.

With this change, any tab would get the updated Viewer without the user noticing

The `event.newValue` contains the stringified version of the `store`. In order to send the same value as line 38, we need to parse it before sending it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant