-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue: Form fields are not updated while traveling in time with the … #17
Open
lucamug
wants to merge
2
commits into
rtfeldman:master
Choose a base branch
from
lucamug:bugfix-textUpdatedDuringHistoryDebug
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Issue: Form fields are not updated while traveling in time with the … #17
lucamug
wants to merge
2
commits into
rtfeldman:master
from
lucamug:bugfix-textUpdatedDuringHistoryDebug
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Elm Time Traveling Debugger Fix: I added the parameter "value" to the input fields with the corresponding value for the model. In case of the Tags field of the Article, because that is created on the fly buy joining the list of tags, I needed to add an extra value in the model, called "unparsedTags". Otherwise the script will always remove spaces at the end of typed text. The fix affect these pages: - http://localhost:8000/#/register - http://localhost:8000/#/login - http://localhost:8000/#/editor - the comment textarea in the Article page
lucamug
changed the title
Issue: Form fields are not updated while travelling in time with the …
Issue: Form fields are not updated while traveling in time with the …
May 22, 2017
lucamug
added a commit
to lucamug/elm-spa-example-old
that referenced
this pull request
May 22, 2017
* bugfix-textUpdatedDuringHistoryDebug: I modified the PR so to not conflict with the PR rtfeldman#17 (rtfeldman#17)
rtfeldman
force-pushed
the
master
branch
2 times, most recently
from
January 15, 2018 04:04
7206535
to
4213d8c
Compare
I'll merge this once 0.19 is out. (There's an annoying bug with Thanks! |
rtfeldman
approved these changes
Mar 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge post-0.19 when the bug with value
is fixed. Thanks!
Do you know when that might be, @rtfeldman? ;) |
Nope. 😄 |
rtfeldman
force-pushed
the
master
branch
8 times, most recently
from
August 27, 2018 15:59
19cab04
to
7a0ff12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Elm Time Traveling Debugger
Fix: I added the parameter "value" to the input fields with the corresponding value for the model.
In case of the Tags field of the Article, because that is created on the fly buy joining the list of tags, I needed to add an extra value in the model, called "unparsedTags". Otherwise the script will always remove spaces at the end of typed text.
The fix affect these pages: