Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Form fields are not updated while traveling in time with the … #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lucamug
Copy link

@lucamug lucamug commented May 22, 2017

…Elm Time Traveling Debugger

Fix: I added the parameter "value" to the input fields with the corresponding value for the model.

In case of the Tags field of the Article, because that is created on the fly buy joining the list of tags, I needed to add an extra value in the model, called "unparsedTags". Otherwise the script will always remove spaces at the end of typed text.

The fix affect these pages:

…Elm Time Traveling Debugger

Fix: I added the parameter "value" to the input fields with the corresponding value for the model.

In case of the Tags field of the Article, because that is created on the fly buy joining the list of tags, I needed to add an extra value in the model, called "unparsedTags". Otherwise the script will always remove spaces at the end of typed text.

The fix affect these pages:

- http://localhost:8000/#/register
- http://localhost:8000/#/login
- http://localhost:8000/#/editor
- the comment textarea in the Article page
@lucamug lucamug changed the title Issue: Form fields are not updated while travelling in time with the … Issue: Form fields are not updated while traveling in time with the … May 22, 2017
lucamug added a commit to lucamug/elm-spa-example-old that referenced this pull request May 22, 2017
* bugfix-textUpdatedDuringHistoryDebug:
  I  modified the PR so to not conflict with the PR rtfeldman#17 (rtfeldman#17)
@rtfeldman rtfeldman force-pushed the master branch 2 times, most recently from 7206535 to 4213d8c Compare January 15, 2018 04:04
@rtfeldman
Copy link
Owner

I'll merge this once 0.19 is out. (There's an annoying bug with value which 0.19 fixes.)

Thanks!

Copy link
Owner

@rtfeldman rtfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge post-0.19 when the bug with value is fixed. Thanks!

@jameshopkins
Copy link

I'll merge this once 0.19 is out

Do you know when that might be, @rtfeldman? ;)

@rtfeldman
Copy link
Owner

Nope. 😄

@rtfeldman rtfeldman force-pushed the master branch 8 times, most recently from 19cab04 to 7a0ff12 Compare August 27, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants