Fix ref issue in DisplayAsWithRef component #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tickevents: remove unused enum values * Remove dupe of CLS, fidv, lj1,lj2 * format
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
…project#36176) * Revert "🏗 Parallelize `dist` steps (ampproject#35943)" This reverts commit 1e2c808. * Partially allow parallelization for smaller tasks * Also include `compileAllJs` in the parallelized part
…5920 (ampproject#36103) removed a unlayout call that would cause the image to default to the first slide
* preact inob: small cleanup * also remove current
* build-system: only write version.txt once * output full set of * sort the paths * write files...not directories * succinct format
* Add styles.css export to package.json * Conditionally add export * Use `fast-glob` * Add separate export entry for each stylesheet * window support * sort for lint Co-authored-by: Jake Fried <[email protected]>
Sweep experiments last flipped globally up to 2021-02-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1
…s.h|cc (ampproject#36184) library. PiperOrigin-RevId: 398102411 Co-authored-by: Amaltas Bohra <[email protected]>
* cl/398081751 Use the proto message number instead of index for enums. * cl/398323481 Two-way sync for PR ampproject#36085. No-op, or fixes merge conflicts, if any. Co-authored-by: honeybadgerdontcare <[email protected]>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
* 📦 Update linting devDependencies * Fix lint errors Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Raghu Simha <[email protected]>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
…#36197) * performance-impl: cant check ampdoc vis hidden before initted * Add unit test
* log * comment
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
…5617) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Raghu Simha <[email protected]>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
* [`bento-facebook`] Update the amp-facebook.md file for both 0.1 and 1.0. Add a README.md for 1.0 bento mode. * [`bento-facebook`] Add documentation to describe the amp-facebook usage outside of valid AMP docs. * [`bento-facebook`] Add readme.md for BentoFacebook. * [`bento-facebook`] Address PR comments to update some attribute names. * [`bento-facebook`] Update CDN link to bento-facebook-1.0.js. * [`bento-facebook`] Prettify amp-facebook.md. * [`bento-facebook`] Update dead link to FB documentation to a real link. * [`bento-facebook`] Update dead links to be valid.
* Remove amp-sidebar code from extensions/amp-story * Remove amp-sidebar visual tests from examples/visual-tests/amp-story * Remove reference to amp-sidebar from amp-story-interactive README * Remove remaining amp-sidebar logic from extensions/amp-story * Remove amp-sidebar logic from amp-story-system-layer code * Remove amp-sidebar code from amp-story-store-service.js * Remove amp-sidebar storybook JS files * A few missed deletions in test-amp-story and build-system/ caught by linter * Revert extensions/amp-sidebar/*/storybook removal from forbidden terms * Add back the amp-sidebar storybook files * Add newline at end of each storybook file * Run amp get-zindex --fix
* Set width on amp-img el. * Add height
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
…36225) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
…ject#36223) Fixes ampproject#36063 `amp-consent` explicitly adds itself to the `FixedLayer`, transferring itself before the iframe is loaded. On a later pass, `FixedLayer` decides that `amp-consent` is not transferrable, so it returns it to the original `<body>` element. Enabling `forceTransfer` causes the return reparenting to not occur, thus preventing the iframe from loading a second time.
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
…#36165) * Update self-host to use amp release `amp release` copies static files and downloaded resources to supplement an `amp dist` runtime. Support custom release flavor definitions and update the amp-framework-hosting documentation. * Fix typo in documentation * Prefer accessing argv instead of passing value * Skip cleaning custom configs by default * Review suggestions
Identify user configuration files under build-system/global-configs as distinct from generated output. This will help avoid accidentally including them in the cleanup script in the future.
AnuragVasanwala
approved these changes
Oct 6, 2021
AnuragVasanwala
added a commit
that referenced
this pull request
Apr 12, 2022
* ✨ Initial Commit * ♻️ Attributes mapped to props * ♻️ Base skeleton with references * ♻️ Added build functions and 🖍 CSS * 🧪 Experimental commit for `Gesture` Service * ♻️ Added `Gesture`, `Mouse` and `Keyboard` Service `prettify` is also performed. * Added `"npm": true` for build-system compilation config Co-Authored-By: Caroline Liu <[email protected]> * 🚮 Removed validator file until rules are added Co-Authored-By: Caroline Liu <[email protected]> * 🚮 Removed unnecessary example code Co-Authored-By: Caroline Liu <[email protected]> * 🚮 Removed `copyright` header from all files Co-Authored-By: Caroline Liu <[email protected]> * ♻️ Cleanup * 🚮 Renoved `Services` Services should not be used in the Preact component. Co-Authored-By: Caroline Liu <[email protected]> * 🧪 Experiment commit, 🚮 Remvoed test `console.log` * 🖍 Added and Formatted `JSS` & `CSS` Co-Authored-By: Caroline Liu <[email protected]> * 🐛 Minor fixes for `JSS` * ♻️ `shouldHintReappear` renamed to more precise name `repeatHint` Co-Authored-By: Caroline Liu <[email protected]> * 🧪 Experimental Test: `DOM` APIs to `JSX` Preact component should not be creating any elements with DOM APIs. Preferring JSX instead. This is an experimental code for my storybook test. * ♻️ Minor fixes and Cleanup * ✨ Added `seekTo` API Function * ♻️ Minor fix to initialise base class * ♻️ Added classes on the JSX node * ⏪ Removed `CSS` Co-Authored-By: Caroline Liu <[email protected]> * ♻️ `ActionTrust` set for only user interaction `DEFAULT` is needed for user interaction whereas `LOW` events could include things like autoplaying carousels. Thus, `DEFAULT` is recommended! Co-Authored-By: Caroline Liu <[email protected]> * ♻️ Removed unnecessary initialisation and import Co-Authored-By: Caroline Liu <[email protected]> * ♻️ `ImageSlider` prefixed with `Bento` The one exception that can stay `ImageSlider` is Storybooks. So, the Storybooks are still alphabetised and searchable without getting clogged up by the `Bento` prefix noise. Co-Authored-By: Caroline Liu <[email protected]> * ♻️ Preact storybook updated with new prefix `Bento` Preact Storybook `title` should be left as `ImageSlider` so it is still alphabetised and searchable without getting clogged up by the `Bento` prefix noise. Co-Authored-By: Caroline Liu <[email protected]> * ♻️ `classList` changed with `class` Always prefer `class` to `classList`. Co-Authored-By: Caroline Liu <[email protected]> * ♻️ `initial-slider-position` type corrected to `number` Co-Authored-By: Caroline Liu <[email protected]> * 🐛 Bug fix for `images` and `labels` Co-Authored-By: Caroline Liu <[email protected]> * ♻️ Updated storybook examples Co-Authored-By: Caroline Liu <[email protected]> * 🚮 Cleanup unnecessary storybook comment * ♻️ `disable-hint-reappear` renamed as `display-hint-once` in Bento `1.0` The intention is to not have an attribute with a negative name, since enabling or disabling it can be confusing to reason about. On second thought, `repeat-hint` is not a good alternative because it flips the default behaviour when omitted. Let's rename to `display-hint-once` or similar, which has the same default omitted/provided behaviour, but perhaps a clearer name. Co-Authored-By: Caroline Liu <[email protected]> * ⏪ Changes to markdown reverted and moved to `0.1` Co-Authored-By: Caroline Liu <[email protected]> * ✨ Added markdown for `1.0` Co-Authored-By: Caroline Liu <[email protected]> * 🐛 Fix for Preact Component API Co-authored-by: Caroline Liu <[email protected]> * 🐛 Minor bug fixes Co-authored-by: Caroline Liu <[email protected]> * ♻️ Validation check added for `percent` attribute Co-authored-by: Caroline Liu <[email protected]> * ♻️ Updated use of `DisplayAs` as a component Co-Authored-By: Caroline Liu <[email protected]> * ♻️ `BentoImageSliderApi` namespace renamed to `Api` for precise meaning Co-Authored-By: Caroline Liu <[email protected]> * 🖍 Added `css` for `1.0`, 🐛 Minor bug fixes and `prettify` Co-Authored-By: Caroline Liu <[email protected]> * ♻️ Minor fix for `percent` validation check * ♻️ Removed superfluous trailing argument for `parseFloat` * 🧪 Experimental Code: Image Reference Issue This commit is intended to check and resolve image reference issue mentioned in discussion: ampproject#35783 (comment) Use keyboard "left" & "right" arrow key to move bar and slide images. Also, focus on the container to enable keyboard input to the component. * Fix ref issue in DisplayAsWithRef component (#5) * tickevents: remove unused enum values (ampproject#36159) * tickevents: remove unused enum values * Remove dupe of CLS, fidv, lj1,lj2 * format * 📦 Update cimg/openjdk Docker tag to v17 (ampproject#36172) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency rollup to v2.57.0 (ampproject#36134) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @octokit/graphql to v4.7.0 (ampproject#35844) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ♻️ Migrate `observeWithSharedInOb` to `observeIntersections` (ampproject#36106) * 🏗 Make setup-node step consistent across gh actions (ampproject#36175) * Partially revert "🏗 Parallelize `dist` steps (ampproject#35943)" (ampproject#36176) * Revert "🏗 Parallelize `dist` steps (ampproject#35943)" This reverts commit 1e2c808. * Partially allow parallelization for smaller tasks * Also include `compileAllJs` in the parallelized part * (amp-lightbox-gallery): opens to selected image, resolve ampproject#35920 (ampproject#36103) removed a unlayout call that would cause the image to default to the first slide * ♻️ preact inob: small cleanup (ampproject#36177) * preact inob: small cleanup * also remove current * build-system: only write version.txt once per dir (ampproject#36162) * build-system: only write version.txt once * output full set of * sort the paths * write files...not directories * succinct format * bind-impl: missing ampStateEl is a user error (ampproject#36113) * Update Yandex & ADFOX amp-ad codes (ampproject#35442) * 🧪Update OT token for attribution-reporting (ampproject#36181) * 🏗 Add `exports` for stylesheets to `package.json` (ampproject#36027) * Add styles.css export to package.json * Conditionally add export * Use `fast-glob` * Add separate export entry for each stylesheet * window support * sort for lint Co-authored-by: Jake Fried <[email protected]> * ✨ [bento][amp-iframe] Add validator rules for 1.0 (ampproject#36182) * 🚮 Sweep experiments older than 2021-02-01 (ampproject#35486) Sweep experiments last flipped globally up to 2021-02-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 * UTF8 encoding/decoding library to deprecated utf8 functions in strings.h|cc (ampproject#36184) library. PiperOrigin-RevId: 398102411 Co-authored-by: Amaltas Bohra <[email protected]> * Validator rollup (ampproject#36185) * cl/398081751 Use the proto message number instead of index for enums. * cl/398323481 Two-way sync for PR ampproject#36085. No-op, or fixes merge conflicts, if any. Co-authored-by: honeybadgerdontcare <[email protected]> * 📦 Update dependency @octokit/rest to v18.11.2 (ampproject#36180) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * deps: bump bento-compiler (ampproject#36191) * 📦 Update dependency @jest/core to v27.2.3 (ampproject#36189) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency esbuild to v0.12.25 (ampproject#35928) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update linting devDependencies (ampproject#36119) * 📦 Update linting devDependencies * Fix lint errors Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Raghu Simha <[email protected]> * 📦 Update dependency axios to 0.21.2 [SECURITY] (ampproject#35999) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency esbuild to v0.13.3 (ampproject#36198) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency tar to v6.1.9 [SECURITY] (ampproject#35509) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * performance-impl: cant check ampdoc vis hidden while null (ampproject#36197) * performance-impl: cant check ampdoc vis hidden before initted * Add unit test * 🏗 Add nice colors to release tagger logs (ampproject#36200) * log * comment * 📦 Update core devDependencies (ampproject#36196) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @ampproject/worker-dom to v0.32.0 (ampproject#36138) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency google-closure-library to v20210808 (ampproject#35617) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * SwG Release 0.1.22.186 (ampproject#36202) * 📦 Update dependency chromedriver to v94 (ampproject#35951) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Raghu Simha <[email protected]> * 📦 Update dependency tar to v6.1.11 (ampproject#36203) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📖 `bento-facebook` Documentation (ampproject#36038) * [`bento-facebook`] Update the amp-facebook.md file for both 0.1 and 1.0. Add a README.md for 1.0 bento mode. * [`bento-facebook`] Add documentation to describe the amp-facebook usage outside of valid AMP docs. * [`bento-facebook`] Add readme.md for BentoFacebook. * [`bento-facebook`] Address PR comments to update some attribute names. * [`bento-facebook`] Update CDN link to bento-facebook-1.0.js. * [`bento-facebook`] Prettify amp-facebook.md. * [`bento-facebook`] Update dead link to FB documentation to a real link. * [`bento-facebook`] Update dead links to be valid. * 🚮 Clean up dead amp-sidebar code within stories (ampproject#36178) * Remove amp-sidebar code from extensions/amp-story * Remove amp-sidebar visual tests from examples/visual-tests/amp-story * Remove reference to amp-sidebar from amp-story-interactive README * Remove remaining amp-sidebar logic from extensions/amp-story * Remove amp-sidebar logic from amp-story-system-layer code * Remove amp-sidebar code from amp-story-store-service.js * Remove amp-sidebar storybook JS files * A few missed deletions in test-amp-story and build-system/ caught by linter * Revert extensions/amp-sidebar/*/storybook removal from forbidden terms * Add back the amp-sidebar storybook files * Add newline at end of each storybook file * Run amp get-zindex --fix * 🐛 [amp-story-panning-media] Set width on amp-img el (ampproject#36217) * Set width on amp-img el. * Add height * 📦 Update dependency @octokit/rest to v18.11.3 (ampproject#36212) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency eslint-plugin-react to v7.26.1 (ampproject#36214) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @ampproject/bento-compiler to v0.0.9 (ampproject#36225) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ♻️Don't fetch crypto signature verifier in no-signing (ampproject#36187) * 🐛 Force transfer of `amp-consent` element to the `FixedLayer` (ampproject#36223) Fixes ampproject#36063 `amp-consent` explicitly adds itself to the `FixedLayer`, transferring itself before the iframe is loaded. On a later pass, `FixedLayer` decides that `amp-consent` is not transferrable, so it returns it to the original `<body>` element. Enabling `forceTransfer` causes the return reparenting to not occur, thus preventing the iframe from loading a second time. * 📦 Update core dependencies (ampproject#35061) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency rollup to v2.58.0 (ampproject#36232) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * 📦 Update dependency @octokit/rest to v18.11.4 (ampproject#36227) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * [bento][amp-iframe] Add README (ampproject#36210) * [bento][amp-iframe] changes to publish to npm (ampproject#36190) * 🐛 fix broken link to Preact/React component section in various README (ampproject#36222) * 🏗 release: Update self-hosting support to use amp release (ampproject#36165) * Update self-host to use amp release `amp release` copies static files and downloaded resources to supplement an `amp dist` runtime. Support custom release flavor definitions and update the amp-framework-hosting documentation. * Fix typo in documentation * Prefer accessing argv instead of passing value * Skip cleaning custom configs by default * Review suggestions * [amp-iframe] iframe viewability (ampproject#36131) * bento amp-iframe: guard effect from running without a win (ampproject#36241) * 🚀 babel/terser: rename all amp privates with sentinel suffix (ampproject#36143) * configs: Separate user configs from output files (ampproject#36236) Identify user configuration files under build-system/global-configs as distinct from generated output. This will help avoid accidentally including them in the cleanup script in the future. * Fix ref issue in DisplayAsWithRef component * Update the fix Co-authored-by: Jake Fried <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: dmanek <[email protected]> Co-authored-by: Esther Kim <[email protected]> Co-authored-by: Daniel Rozenberg <[email protected]> Co-authored-by: William Johnson <[email protected]> Co-authored-by: Mikhail Troshev <[email protected]> Co-authored-by: Caleb Cordry <[email protected]> Co-authored-by: Pascal Birchler <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Allan Banaag <[email protected]> Co-authored-by: Amaltas Bohra <[email protected]> Co-authored-by: honeybadgerdontcare <[email protected]> Co-authored-by: Raghu Simha <[email protected]> Co-authored-by: qidonna <[email protected]> Co-authored-by: rebeccanthomas <[email protected]> Co-authored-by: Corey Masanto <[email protected]> Co-authored-by: Philip Bell <[email protected]> Co-authored-by: Alan Orozco <[email protected]> Co-authored-by: Matt Mower <[email protected]> Co-authored-by: Anurag Vasanwala <[email protected]> * Fix bento slider issues (#12) * Refactor bento amp image slider markup * Fix label styling * Fix hints and slider touch gestures * Add storybook styling for custom label and hints * Remove unneccesary code * Add comments for `containerClass` and `initLogContructor` * Update import path using alias * ♻️ Update alias, update AMP example * 🏗 Update compilation config * 🖍 Fix for `amp-img` size * ♻️ Update image `selector` order * ♻️ Minor fix passing class name * Fix bento image slider misc issues (#14) * Add slot for custom hints and fix label markup * Implement display-hint-once option and cleanup code * Fix LGTM check * Fix LGTM check * Use ContainWrapper for component wrapper * Fix circleCI checks * Add unit test cases for amp-image-slider component * Update initial position attribute in storybook * Add unit test code coverage * Fix flaky test cases * Fix unit test cases * Remove image slider 1.0 example file * Remove unused code * Remove unused code * Fix unlisten event function logic * ♻️ Minor fix, `lint` and `prettify` * ♻️ Update derived class extends using `setSuperClass` * ♻️ Correct dead links in `markdown` * ♻️ Remove `@storybook/addon-knobs` dependency from storybook * ♻️ Allow `src/service/timer-impl.js` dependency * ♻️ Update `Z_INDEX.md` * ♻️ Add check for `initialPosition` and `stepSize` * 🐛 Update `isFiniteNumber` with `isNaN` Co-authored-by: Caroline Liu <[email protected]> Co-authored-by: Edi Amin <[email protected]> Co-authored-by: Jake Fried <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: dmanek <[email protected]> Co-authored-by: Esther Kim <[email protected]> Co-authored-by: Daniel Rozenberg <[email protected]> Co-authored-by: William Johnson <[email protected]> Co-authored-by: Mikhail Troshev <[email protected]> Co-authored-by: Caleb Cordry <[email protected]> Co-authored-by: Pascal Birchler <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Allan Banaag <[email protected]> Co-authored-by: Amaltas Bohra <[email protected]> Co-authored-by: honeybadgerdontcare <[email protected]> Co-authored-by: Raghu Simha <[email protected]> Co-authored-by: qidonna <[email protected]> Co-authored-by: rebeccanthomas <[email protected]> Co-authored-by: Corey Masanto <[email protected]> Co-authored-by: Philip Bell <[email protected]> Co-authored-by: Alan Orozco <[email protected]> Co-authored-by: Matt Mower <[email protected]> Co-authored-by: Deepak Lalwani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AnuragVasanwala Currently the ref is not working in
DisplayAsWithRefbecause we are not setting the ref into the main component that we are passing in Basic.js as thefirstImageAsorsecondImageAsprop.