only test getItem, show useful warning outside of prod

rt2zz · Nov 12, 2016 · 19c96cd · IanVS · Nov 15, 2016 · rt2zz
1 parent 89ee329
commit 19c96cd
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/defaults/asyncLocalStorage.js b/src/defaults/asyncLocalStorage.js
@@ -14,11 +14,13 @@ function hasLocalStorage () {
     storageExists = (typeof window === 'object' && !!window.localStorage)
     if (storageExists) {
       const testKey = 'redux-persist localStorage test'
-      window.localStorage.setItem(testKey, true)
+      // @TODO should we also test set and remove?
       window.localStorage.getItem(testKey)
-      window.localStorage.removeItem(testKey)
     }
-  } catch (e) { return false }
+  } catch (e) {
+    if (process && process.env && process.env.NODE_ENV === 'production') console.warn('redux-persist localStorage getItem test failed, persistence will be disabled.')
+    return false
+  }
   return storageExists
 }