-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ENV var to configure dry run #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this suggestion @igas I agree that having spec logic in application.rb
seems a bit off the mark- I've had to do the same as well 😄 .
This looks like a very good improvement- I would only request that you update this section in the README to reflect the change. cc @BookOfGreg
Hi @BookOfGreg, any chance you can take a look at this one? |
Code looks ok. I'd like to see a test related to the change. I'll probably merge either this or something similar after OA3 changes as that's the majority of the effort just now. |
No worries, thanks a lot for work on OA3, we can't wait to test it out. |
Looking forward for sth like this to be merged, cuz the current master's README section about DryRun doesn't work. The issue with current master branch is that, when doing |
May I ask what the status of this feature is? It seems to be approved and ready to be merged? |
@gerardo-navarro thanks for the bump. This feature is now in the 2.4.0 release. |
During integration with rswag, we noticed that we need to set dry run very early and suggestion is to put it in
application.rb
. We did not really want to add specs related code to production code. So we came up with this solution. What do you think?