Ensure texture loading happens on the main thread #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Will Jordan <[email protected]>
|
Excellent - I just |
|
Works fine on my case as well, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101.
Godot 4.3 had a core change with multi-threaded resource loading. This now occurs in a thread, and
call_deferredis no longer a viable "hack" to ensure it runs on the main thread. To ensure this, such scenarios were changed to depend on theControllerIconssingleton for ensuring a function call is executed on the main thread.@plink-plonk-will this is essentially the same approach of #96, so I've added you as a co-author. I only decided to simplify it by keeping the logic on the texture icon code, keeping the singleton side as simple as possible.