Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xgboost check #290

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Add xgboost check #290

merged 1 commit into from
Oct 9, 2024

Conversation

mfansler
Copy link
Contributor

@mfansler mfansler commented Oct 9, 2024

Adds a skip when xgboost is not installed. Otherwise, test will fail with:

── Error ('test-mlr3.R:34:5'): learners from mlr3learners can be pinned ────────
<packageNotFoundError/error/condition>
Error: The following packages could not be loaded: xgboost
Backtrace:1. └─learner$train(task) at test-mlr3.R:34:5
 2.   └─mlr3:::.__Learner__train(...)
 3.     └─mlr3:::learner_train(...)
 4.       └─mlr3misc::require_namespaces(learner$packages)

Copy link
Member

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@juliasilge juliasilge merged commit 54996d5 into rstudio:main Oct 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants