Migrate to testthat edition 3 #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
added a commit
to teunbrand/thematic
that referenced
this pull request
Jun 12, 2025
* Avoid using deprecated context() * Try setting testthat edition 3 * Skip on CI and add a note about why
cpsievert
added a commit
that referenced
this pull request
Jun 12, 2025
* stabilise default getter * try to fix ggplot_build shenannigans * be more strict about restoring blank properties * skip test * namespace `is_theme_element()` * Code review * Use dev evaluate to fix README rendering bug (#159) * Use dev evaluate to fix README rendering bug * Avoid Remotes field * `devtools::build_readme()` (GitHub Actions) --------- Co-authored-by: cpsievert <[email protected]> * Migrate from shinytest to shinytest2 (#158) * Migrate to testthat edition 3 (#160) * Avoid using deprecated context() * Try setting testthat edition 3 * Skip on CI and add a note about why * Update visual baselines (using ggplot2 v3.5.2 and R 4.5.0) * Update visual baselines (using ggplot2-dev v4.0.0 and R 4.5.0) * Update shiny visual baselines (using ggplot2-dev v4.0.0 and R 4.5.0) * Revert "Code review" This reverts commit fd3735b. * Undo ggplot2 requirement --------- Co-authored-by: Carson Sievert <[email protected]> Co-authored-by: cpsievert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started out as an attempt to fix the fact that snapshots tests currently always passes since, when
R CMD checkhappens, the_snapsfolder no longer exists (and so we end up with a bunch of warnings that snapshots are being added)Turns out, since
_snapsis in.Rbuildignore(for good reason), there isn't a good way to do the testing as a part ofR CMD check.Maybe someday we'll also run
devtools::test(), but for now, let's just run tests locally.