Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create bucket_list_tag #26

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Create bucket_list_tag #26

wants to merge 4 commits into from

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Jul 3, 2019

Fixes #20

Allows for bucket_lists to be made from sortable_js objects directly

* master:
  Export question_is_valid()
  Update the animated gifs
  Correctly import learnr methods
  Remove old parsons images
  Update tutorial
  Include S3 method for question_try_again_input
  Remove rsconnect artefact, since pkgdown can't deal with it
  Ignore rsconnect deployment artefacts
  Add tutorial to _pkgdown.yml
  Add shinyapps.io dcf file for tutorial
  Publish tutorial on shinyapps.io
  Include tutorial in examples
  Add github.io url to _pkgdown.yml
  Ignore html from vignettes and tutorials
  Use rstudio/learnr
@schloerke schloerke requested a review from andrie July 3, 2019 15:12
@codecov-io
Copy link

codecov-io commented Jul 3, 2019

Codecov Report

Merging #26 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   94.11%   94.19%   +0.07%     
==========================================
  Files          10       10              
  Lines         221      224       +3     
==========================================
+ Hits          208      211       +3     
  Misses         13       13
Impacted Files Coverage Δ
R/bucket_list.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01170fd...b9848dc. Read the comment docs.

@schloerke
Copy link
Collaborator Author

Deferring until second release

@schloerke schloerke added this to the v1.1.0 milestone Jul 8, 2019
@schloerke schloerke marked this pull request as draft June 5, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experiment with different API for bucketable_list
2 participants