feat!(submitButton): don't treat any HTML type='submit' button/input like a submitButton()#4209
Merged
feat!(submitButton): don't treat any HTML type='submit' button/input like a submitButton()#4209
type='submit' button/input like a submitButton()#4209Conversation
…like a submitButton()
cpsievert
commented
Apr 25, 2025
schloerke
reviewed
May 1, 2025
schloerke
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is needed for rstudio/bslib#1204, which proposes a more fully featured
input_submit_button(), as well as ainput_submit_textarea(). In both cases, it will be nice (if not necessary) to includetype="submit"on the buttons. Unfortunately, that means that shiny.js will suspend all inputs until submit, which is not what we want.Technically this is a breaking change, but there is guidance in the NEWS for back-compat if someone happens to be relying on the current behavior.
Closes posit-dev/py-shiny#1770