Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace {viridis} dependency by {viridisLite} #897

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Dec 13, 2023

Pull Request

Since all the functions used by leaflet from viridis are reexported from viridisLite.

This reduces the total number of leaflet dependencies from 64 to 49.

PR task list:

  • Update NEWS
  • Add tests (where appropriate)
    • R code tests: tests/testthat/
    • Visual tests: R/zzz_viztest.R
  • Update documentation with devtools::document()

@olivroy olivroy changed the title Replace viridis by viridisLite. Replace viridis dependency by viridisLite. Dec 13, 2023
@olivroy
Copy link
Contributor Author

olivroy commented Feb 16, 2024

I think it would be worth considering, since viridis adds 11 dependencies. With this PR, leaflet would only import 52 packages (compared to 63 currently)

@schloerke schloerke changed the title Replace viridis dependency by viridisLite. Replace {viridis} dependency by {viridisLite} Feb 16, 2024
@schloerke schloerke merged commit 7ae5ca3 into rstudio:main Feb 16, 2024
1 check passed
@olivroy olivroy deleted the viridisLite branch February 16, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants