Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Use v1 timezones API.
Because this is a really simple switch, I took the opportunity to think about how to handle checking the server version before trying the old request.
Currently not ready. Right now the server version isn't cached in any way so it results in two requests every time, and is no better than just trying the new URL first.
There are a bunch of existing functions around checking the server version, but they grouped "version not available" with "old version", which is the opposite of what we need, so I did some light refactoring to treat "version not available" as
NULL
and preserve that. I don't know if I like this approach though; maybe better to just not touch those functions and write aversion
as a dynamic, cached property of the server object.Fixes #300
Approach
Checklist
NEWS.md
(referencing the connected issue if necessary)?