Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade pkgdown to bootstrap 5 #306

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

fh-mthomson
Copy link
Contributor

Intent

Address pkgdown aspect of #275

Approach

When setting up pkgdown in a new package, via usethis::use_pkgdown() programmatically adds:

template:
  bootstrap: 5

Which should be minimally sufficient to enable search by default, from what I've seen in developing other packages.

Related docs:

Testing

I'm unable to run pkgdown::build_site() locally, given vignettes that require certain test artifacts to be accessible from a Connect instance. I'll take a look at the resulting CI logs, but a bit limited in being able to test more than that, from what I can tell.

Checklist

  • Does this change update NEWS.md (referencing the connected issue if necessary)?
  • Does this change need documentation? Have you run `document()?

@toph-allen toph-allen self-requested a review September 24, 2024 21:09
@toph-allen toph-allen changed the title upgrade pkgdown to bootstrap 5 chore: upgrade pkgdown to bootstrap 5 Oct 8, 2024
@toph-allen toph-allen mentioned this pull request Oct 8, 2024
Copy link
Collaborator

@toph-allen toph-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good. CI passed in #310. I'll take it from here and get it merged.

@toph-allen toph-allen merged commit 6085b53 into rstudio:main Oct 8, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants