fix: Web-Components/Vue3: Update core presets to extend existing config

[valentinpalkovic]

The existing core preset configuration was not propagated for the Web Components and Vue3 frameworks, leading to errors on our CI by applying a security fix for our WebSocket connection. See: storybookjs/storybook#33820

[gemini-code-assist]

Summary of Changes

Hello @valentinpalkovic, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the core preset configuration was not being fully propagated to the Vue3 and Web Components frameworks. By explicitly extending the existing configuration, it ensures that all necessary settings, including recent security fixes for WebSocket connections, are correctly applied, thereby preventing related CI failures.

Highlights

• Core Preset Configuration: Ensured that the core preset configuration is properly extended for the Vue3 and Web Components frameworks.
• CI Stability: Resolved CI errors that occurred due to a security fix for WebSocket connections not being correctly applied in these frameworks.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• packages/framework-vue3/src/preset.ts
  • Updated the core preset to correctly extend the incoming configuration object using the spread operator.
• packages/framework-web-components/src/preset.ts
  • Updated the core preset to correctly extend the incoming configuration object using the spread operator.

Activity

• No specific activity was provided in the context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the core presets for Vue3 and Web-Components to extend the existing configuration instead of overwriting it. This is achieved by spreading the incoming config object into the returned preset object. The change is a necessary bug fix. I've also pointed out an opportunity to reduce code duplication between the two modified preset files, which could be addressed in a future refactoring to improve maintainability.

[fi3ework]

Thank you for the notification and the PR!