Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated output.charset option from rspack-chain to align with upstream Rspack changes (ref: web-infra-dev/rspack#12660).
Changes:
- Removed
charsetmethod from Output class implementation - Removed
charsettype definition from TypeScript declarations - Updated test file to remove
charsetusage - Updated documentation to remove
charsetreference
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Output.js | Removed 'charset' from the shorthands array in the Output class |
| types/index.d.ts | Removed charset method declaration from Output class type definition |
| types/test/rspack-chain-tests.ts | Removed .charset(true) call from output configuration test |
| README.md | Removed .charset(charset) from the output shorthand methods documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: web-infra-dev/rspack#12660