orderedset.update -> should be iterable

[svaningelgem]

Current:

    def update(self, sequence: Union[Sequence[T], Set[T]]) -> int:

Proposed:

    def update(self, sequence: Iterable[T]) -> int:

The reason is that I push in a generator, which works just fine. But the IDE complains because it's neither a Sequence, nor a Set.

[nathanielmanistaatgoogle]

Just bonked my head against this today.

Hey @rspeer: might you happen to have assessed how hard this would be to fix? Would it be, as @svaningelgem described, as simple as changing this line from requiring SetLike[T] to merely requiring Iterable[T]?

Python's built-in set is specified as being able to take any Iterable ("Note, [...] update(), [...] will accept any iterable as an argument"), so there's currently a clash with the way OrderedSet.update requires a SetLike.

---

... although fiddlesticks; now that I'm reading carefully about set.update, I see that its parameter is actually *others, so I suppose it would be even more of an improvement to change the line to

def update(self, *others: Iterable[T]) -> int:

... 🤔

(But the lesser change would still be helpful on its own, even if we couldn't make the larger change all the way to *others.)