Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make filetype infer opt-in #967

Closed
wants to merge 2 commits into from
Closed

Make filetype infer opt-in #967

wants to merge 2 commits into from

Conversation

xaviershay
Copy link
Member

Begins to address #662

  • Configuration is a bang method rather than a setting, because we don't have a public API for "un-including" modules.
  • As a result there is no way to make this "opt-out" without requiring a breaking change to config.
  • Newly generated spec_helper.rb will opt-in, with an explanatory comment.

DO NOT MERGE: Needs a 2.99 deprecation. Needs to be based against master after ammeter branch is merged.

@alindeman @myronmarston

@xaviershay xaviershay mentioned this pull request Mar 23, 2014
Closed
@alindeman alindeman closed this Mar 23, 2014
@xaviershay xaviershay mentioned this pull request Mar 23, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xaviershay @alindeman