Run before(:all) hooks for rails magic example groups

lib/rspec/rails/example/controller_example_group.rb

@@ -146,6 +146,7 @@ def method_missing(method, *args, &block)
       subject { controller }
 
       metadata[:type] = :controller
+      hooks.register_globals(self, RSpec.configuration.hooks)
 
       before do
         self.routes = ::Rails.application.routes

lib/rspec/rails/example/feature_example_group.rb

@@ -7,6 +7,7 @@ module FeatureExampleGroup
 
     included do
       metadata[:type] = :feature
+      hooks.register_globals(self, RSpec.configuration.hooks)
 
       app = ::Rails.application
       if app.respond_to?(:routes)

lib/rspec/rails/example/helper_example_group.rb

@@ -31,6 +31,7 @@ def _controller_path(example)
 
     included do
       metadata[:type] = :helper
+      hooks.register_globals(self, RSpec.configuration.hooks)
 
       before do |example|
         controller.controller_path = _controller_path(example)

lib/rspec/rails/example/mailer_example_group.rb

@@ -7,6 +7,8 @@ module MailerExampleGroup
 
       included do
         metadata[:type] = :mailer
+        hooks.register_globals(self, RSpec.configuration.hooks)
+
         include ::Rails.application.routes.url_helpers
         options = ::Rails.configuration.action_mailer.default_url_options
         options.each { |key, value| default_url_options[key] = value } if options

lib/rspec/rails/example/model_example_group.rb

@@ -5,6 +5,7 @@ module ModelExampleGroup
 
     included do
       metadata[:type] = :model
+      hooks.register_globals(self, RSpec.configuration.hooks)
     end
   end
 end

lib/rspec/rails/example/rails_example_group.rb

@@ -10,6 +10,12 @@ module RailsExampleGroup
       include RSpec::Rails::MinitestLifecycleAdapter if ::Rails::VERSION::STRING >= '4'
       include RSpec::Rails::MinitestAssertionAdapter
       include RSpec::Rails::Matchers
+
+      def set_metadata_type(type)
+        metadata[:type] = type
+        hooks.register_globals(self, RSpec.configuration.hooks)
+      end
+
     end
   end
 end

lib/rspec/rails/example/request_example_group.rb

@@ -14,6 +14,7 @@ def app
 
     included do
       metadata[:type] = :request
+      hooks.register_globals(self, RSpec.configuration.hooks)
 
       before do
         @routes = ::Rails.application.routes

lib/rspec/rails/example/routing_example_group.rb

@@ -31,6 +31,7 @@ def routes(&blk)
 
     included do
       metadata[:type] = :routing
+      hooks.register_globals(self, RSpec.configuration.hooks)
 
       before do
         self.routes = ::Rails.application.routes

lib/rspec/rails/example/view_example_group.rb

@@ -143,6 +143,8 @@ def _include_controller_helpers
       include ExampleMethods
 
       metadata[:type] = :view
+      hooks.register_globals(self, RSpec.configuration.hooks)
+
       helper(*_default_helpers)
 
       before do

spec/rspec/rails/example/controller_example_group_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-class ::ApplicationController
+class ::ApplicationController < ActionController::Base
 end
 
 module RSpec::Rails
@@ -96,5 +96,7 @@ module RSpec::Rails
         controller_class.superclass.should eq(ApplicationController)
       end
     end
+
+    it_behaves_like "runs metadata hooks of :type =>", :controller, ControllerExampleGroup
   end
 end

spec/rspec/rails/example/feature_example_group_spec.rb

@@ -52,5 +52,7 @@ def visit(url)
         expect(group.new.visit("/foo")).to eq("success: /foo")
       end
     end
+
+    it_behaves_like "runs metadata hooks of :type =>", :feature, FeatureExampleGroup
   end
 end

spec/rspec/rails/example/helper_example_group_spec.rb

@@ -51,6 +51,8 @@ def _view
         group.new.helper.should be_kind_of(ApplicationHelper)
       end
     end
+
+    it_behaves_like "runs metadata hooks of :type =>", :helper, HelperExampleGroup
   end
 
   describe HelperExampleGroup::ClassMethods do

spec/rspec/rails/example/mailer_example_group_spec.rb

@@ -17,5 +17,7 @@ module ::Rails; end
       end
       group.metadata[:type].should eq(:mailer)
     end
+
+    it_behaves_like "runs metadata hooks of :type =>", :mailer, MailerExampleGroup
   end
 end

spec/rspec/rails/example/model_example_group_spec.rb

@@ -11,5 +11,7 @@ module RSpec::Rails
       end
       group.metadata[:type].should eq(:model)
     end
+
+    it_behaves_like "runs metadata hooks of :type =>", :model, ModelExampleGroup
   end
 end

spec/rspec/rails/example/request_example_group_spec.rb

@@ -13,5 +13,7 @@ module RSpec::Rails
       end
       group.metadata[:type].should eq(:request)
     end
+
+    it_behaves_like "runs metadata hooks of :type =>", :request, RequestExampleGroup
   end
 end

spec/rspec/rails/example/routing_example_group_spec.rb

@@ -28,5 +28,7 @@ module RSpec::Rails
         example.foo_path.should == "foo"
       end
     end
+
+    it_behaves_like "runs metadata hooks of :type =>", :routing, RoutingExampleGroup
   end
 end

spec/rspec/rails/example/view_example_group_spec.rb

@@ -216,5 +216,7 @@ def _view; end
         view_spec.template
       end
     end
+
+    it_behaves_like "runs metadata hooks of :type =>", :view, ViewExampleGroup
   end
 end

spec/support/helpers.rb

@@ -16,5 +16,11 @@ def metadata_with(additional_metadata)
     m
   end
 
+  def with_isolated_config
+    config = RSpec.configuration
+    yield config.dup if block_given?
+    RSpec.configuration = config
+  end
+
   RSpec.configure {|c| c.include self}
 end

spec/support/hook_shared_examples.rb

@@ -0,0 +1,22 @@
+shared_examples_for "runs metadata hooks of :type =>" do |type, type_group|
+
+  [:before, :after].each do |hook|
+    [:all, :each].each do |scope|
+
+      it "runs #{hook} #{scope} hooks before groups of #{type}" do
+        with_isolated_config do |config|
+          run_count = 0
+          config.send(hook, scope, :type => type) { run_count += 1 }
+          group = RSpec::Core::ExampleGroup.describe do
+            include type_group
+            specify { true }
+          end
+          group.run RSpec::Core::Reporter.new
+          expect(run_count).to eq 1
+        end
+      end
+
+    end
+  end
+
+end