Bypass using the prerelease versions of rspec #2576
Closed
zspencer wants to merge 1 commit intorspec:combo-have_enqueued_mail-fixesfrom
zinc-collective:combo-have_enqueued_mail-fixes
Closed
Bypass using the prerelease versions of rspec #2576zspencer wants to merge 1 commit intorspec:combo-have_enqueued_mail-fixesfrom zinc-collective:combo-have_enqueued_mail-fixes
prerelease versions of rspec #2576zspencer wants to merge 1 commit intorspec:combo-have_enqueued_mail-fixesfrom
zinc-collective:combo-have_enqueued_mail-fixes
Conversation
Here, @pirj shows us how to use the Rails 7 compatible branch: - #2546 (comment) Then, I got confused about what to do with the other changes: - #2546 (comment) So, to make it a bit easier to just "drop in" a the ActionMailer fixes, this branch makes rspec-rails "feel like" a released version of itself, so bundling off of it doesn't incidentally pull in the pre-release version of rspec. There's nothing wrong with the pre-release version of rspec, but I'm not particularly confident making the recommended other changes to my consuming applications codebase; so a quick fork until a real 5.1.1 or 6.0 release comes out seems "safest"
zspencer
added a commit
to zinc-collective/convene
that referenced
this pull request
Mar 1, 2022
See: rspec/rspec-rails#2576 Basically, turns out there _is_ a version of rspec-rails that works with Rails 7, however it is living in a branch atm because it's a big change. (totally reasonable). This uses a forked version of that branch, because it expects to be a prerelease version, and I wasn't sure how to move my Gemfile to use pre-release versions of itself, and once I started going down that path I got skared.
zspencer
added a commit
to zinc-collective/convene
that referenced
this pull request
Mar 2, 2022
* Get Dependencies in order - Sprockets was removed from Rails core, and now lives in it's own gem https://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#sprockets-is-now-an-optional-dependency - spring-watch-listen has been migrated to the rails core team, but they haven't released the version that supports spring 3+: rails/spring-watcher-listen#27 * Rails 7 and Lockbox have synonymous APIs Fancy pants support for application-level encryption of data has been added to Rails! Yay https://guides.rubyonrails.org/active_record_encryption.html However, it uses the same method name as Lockbox: https://github.com/ankane/lockbox#active-record So we use the Lockbox-specific one now. * Use the Rails 7 Defaults * Database schema is shaped a touch different with the new defaults * Update rspec-railsy-bits * Use the branch of rspec-rails that supports Rails 7 See: rspec/rspec-rails#2576 Basically, turns out there _is_ a version of rspec-rails that works with Rails 7, however it is living in a branch atm because it's a big change. (totally reasonable). This uses a forked version of that branch, because it expects to be a prerelease version, and I wasn't sure how to move my Gemfile to use pre-release versions of itself, and once I started going down that path I got skared. * Run `bin/rails app:update` * Explicitly disable tls for maildev Not entirely sure why we need to do this now, but OK. See: maildev/maildev#274 Co-authored-by: Zee Spencer <zspencer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, @pirj shows us how to use the Rails 7 compatible branch:
Then, I got confused about what to do with the other changes:
So, to make it a bit easier to just "drop in" a the ActionMailer fixes,
this branch makes rspec-rails "feel like" a released version of itself,
so bundling off of it doesn't incidentally pull in the pre-release
version of rspec.
There's nothing wrong with the pre-release version of rspec, but I'm not
particularly confident making the recommended other changes to my
consuming applications codebase; so a quick fork until a real 5.1.1 or
6.0 release comes out seems "safest"