Fix parameter matching with mail delivery job and ActionMailer::MailDeliveryJob

[fabn]

This should fix #2351.

Maybe it's a breaking change for Rails 6 users, I don't know but it will allow users to easily upgrade to rails 6 without changing tons of specs.

Let me know if it's ok, it's my first PR in rspec.

[pirj]

Please feel free to locally disable Metrics/ClassLength for this class.

[pirj]

Good job! Thank you for the contribution.

[FriedSock]

Thank you @fabn! Can we merge this now? I'd love to have this change.

[fabn]

Thank you @fabn! Can we merge this now? I'd love to have this change.

I'm not a maintainer, I don't know when this will be merged. @pirj?

[pirj]

@mico @dmitry Does it fix your cases, too?

[pirj]

Please accept my apologies, I completely forgot about this PR @fabn

[fabn]

Should it be like that? Rails API docs suggest using a symbol for the key:

Copy pasted from existing examples, I can change them

[fabn]

@pirj Pushed a new commit to have different examples for each syntax

[pirj]

Looks good. Thanks for moving this forward.
A couple of small fixes/clarifications and it's good to go.

[pirj]

@mico @dmitry Ping. Does this PR fix your cases?

[pirj]

@fabn Thanks a lot, looks flawless to me.

@JonRowe Any objections to merging this?

[Haegin]

I've just run in to this when upgrading to Rails 6 myself - is there anything I can do to help get this over the line?

[pirj]

Sure, just take a look at the PR, and make it work locally for Rails 5.2, 6.0 and 7.0. You can send a patch, or open a pr basing on what has been done, your choice. That would be very helpful as as  7.0 was just released.

[pirj]

@Haegin Please accept my apologies, I replied without looking.
I suggest you to use this branch in your Gemfile while the PR is not merged.

[dmitry]

@pirj on the next week going to check this branch in the project.

[dmitry]

Just tested and seems it works in the following cases:

expect {
          expect {
            request!
          }.to have_enqueued_mail(LeadMailer, :user_created)
                 .with(
                   a_hash_including(
                     params: {
                       user: instance_of(User)
                     }
                   )
                 )
        }.to have_enqueued_mail(DeviseMailer, :confirmation_instructions)
               .with(
                 args: [
                   instance_of(User),
                   instance_of(String),
                   {}
                 ]
               )

Now it looks like this:

expect {
          expect {
            request!
          }.to have_enqueued_mail(LeadMailer, :user_created)
                 .with(
                   user: instance_of(User)
                 )
        }.to have_enqueued_mail(DeviseMailer, :confirmation_instructions)
               .with(
                 instance_of(User),
                 instance_of(String),
                 {}
               )

Means it still works and I have to write less code.

👍 for the feature! 🚀

[pirj]

I had to make this change to make this change pass on both Rails 7 and Rails 6.0. Kindly appreciate your feedback.

[pirj]

Fixed in #2546. Thanks for your contribuion, @fabn !

[fabn]

You're welcome