Fix support for Rails 4.2 #2480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 4.2 does not have `use_transactional_tests` defined Fix rspec#2477
tagliala
commented
Mar 10, 2021
| # and let(:method_name) before Rails 6.1. | ||
| def run_in_transaction? | ||
| use_transactional_tests && !self.class.uses_transaction?(self) | ||
| if ::Rails::VERSION::STRING > '5' |
Author
There was a problem hiding this comment.
This check is inspired by
pirj
approved these changes
Mar 10, 2021
Member
pirj
left a comment
pirj
left a comment
There was a problem hiding this comment.
Looks good, thank you!
Please add a Changelog record.
Author
|
Is the failure |
Member
|
Might be just flaky. Let's see if it reappears after Changelog changes. |
Member
|
Thank you! |
Member
|
Thanks, this will be released later today as 4.1.2. (Please note future travellers, this does not mean we are supporting Rails 4.2 on this series of RSpec, this was an exception to the rule 😃 ) |
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 4.2 does not have
use_transactional_testsdefinedFix #2477
Supersedes #2479 (I was using a wrong branch)