Correct route_to documentation in README #2418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `route_to` matcher [delegates to assert_recognizes](https://github.com/rspec/rspec-rails/blob/main/lib/rspec/rails/matchers/routing_matchers.rb#L27). This assertion only tests path=>params, not that the provided params also generate the expected path [as `assert_routing` does](https://api.rubyonrails.org/v6.1.0/classes/ActionDispatch/Assertions/RoutingAssertions.html). It would be great to have an rspec matcher for the inverse (`generate_route` perhaps?) but at the very least I figured the readme should be corrected. The full docs on relishapp.com seem to be correct already.
JonRowe
approved these changes
Dec 17, 2020
Member
|
Thanks! |
JonRowe
added a commit
that referenced
this pull request
Dec 26, 2020
Correct route_to documentation in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
route_tomatcher delegates to assert_recognizes. This assertion only tests path=>params, not that the provided params also generate the expected path asassert_routingdoes.It would be great to have an rspec matcher for the inverse (
generate_routeperhaps?) but at the very least I figured the readme should be corrected. The full docs on relishapp.com seem to be correct already.