-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EmptyTemplateHandler fix arguments #2089
Conversation
lib/rspec/rails/view_rendering.rb
Outdated
@@ -102,7 +102,7 @@ def find_templates(*args) | |||
|
|||
# @private | |||
class EmptyTemplateHandler | |||
def self.call(_template) | |||
def self.call(*) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's preferable to have 1 required, 1 optional, just because it matches their API
If possible can we get a test for this? |
there're already about 15 tests failing on rails master, so I don't think it's necessary https://travis-ci.org/rspec/rspec-rails/jobs/499366086
|
Fair enough |
Didn't see it. Thanks! |
… arguments fixed - rspec/rspec-rails#2089 Bumped zeitwerk as well.
Can we backport this to 3.x and release a new version? /cc @JonRowe |
Sorry no, work to release 4.0.0 is under way and it will be released soon, but its too much maintenance work to support Rails 6 in 3.x. |
fixes #2086