This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Remove mentions of legacy methods #1567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
reviewed
Jan 26, 2024
| # fluent interface that `should_receive` and `stub` have always | ||
| # supported, allowing you to constrain the arguments or number of | ||
| # to receive. The object returned by `receive` supports a fluent | ||
| # interface, allowing you to constrain the arguments or number of |
Member
There was a problem hiding this comment.
This is fine, are you leaving this open to collect more?
Member
Author
There was a problem hiding this comment.
No, the build was afwully ted and I decided to fix builds first, but it also was red on main
And I’ll to sync all changes from main yo 4-0-dev to incorporate all build fixes you recently did, and to align the two branches
Member
There was a problem hiding this comment.
As its just docs you can just merge this then fix it.
JonRowe
pushed a commit
to rspec/rspec
that referenced
this pull request
Nov 27, 2024
…entions-of-legacy-methods Remove mentions of legacy methods --- This commit was imported from rspec/rspec-mocks@8b0c3a8.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1365