This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Merged
Conversation
pirj
force-pushed
the
update-cucumber
branch
4 times, most recently
from
73bed2b to
f75831e
Compare
This was referenced Sep 5, 2021
pirj
force-pushed
the
update-cucumber
branch
4 times, most recently
from
9ac0472 to
d28790d
Compare
Member
Author
|
I failed to properly install JRuby 9.1.17.0 quickly locally. |
pirj
force-pushed
the
update-cucumber
branch
2 times, most recently
from
44c7075 to
26bdaef
Compare
pirj
commented
Sep 12, 2021
| if ::RSpec::Support::RubyFeatures.ripper_supported? | ||
| block.call | ||
| else | ||
| warn "Skipping scenario #{scenario.title} because Ripper is not supported" |
pirj
commented
Sep 12, 2021
| warn "Skipping scenario #{scenario.title} because Ripper is not supported" | ||
| unless ::RSpec::Support::RubyFeatures.ripper_supported? | ||
| warn "Skipping scenario #{scenario.name} because Ripper is not supported" | ||
| skip_this_scenario |
Member
Author
There was a problem hiding this comment.
cucumber 4.0.0 is not aware of breaking changes in diff-lcs 1.4.3, so excluding it cucumber 4.0.0 would run on Ruby 2.3, 2.4 and JRuby 9.1
pirj
force-pushed
the
update-cucumber
branch
from
7636c3d to
85147ad
Compare
JonRowe
approved these changes
Sep 13, 2021
pirj
added a commit
to rspec/rspec-rails
that referenced
this pull request
Sep 18, 2021
cucumber 4.0.0 is not aware of breaking changes in diff-lcs 1.4.3, so excluding it cucumber 3.2 would run on Ruby 2.2, 2.3 and 2.4 Sibling PRs: - rspec/rspec-core#2877 - rspec/rspec-mocks#1439 - rspec/rspec-expectations#1320
pirj
added a commit
to rspec/rspec-rails
that referenced
this pull request
Sep 18, 2021
cucumber 4.0.0 is not aware of breaking changes in diff-lcs 1.4.3, so excluding it cucumber 3.2 would run on Ruby 2.2, 2.3 and 2.4 Sibling PRs: - rspec/rspec-core#2877 - rspec/rspec-mocks#1439 - rspec/rspec-expectations#1320
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.3-2.0 don't work for me locally with a weird error:
2.4.0 spits "undefined method
with_filtered_backtrace" in some other repository (rspec-coreto my best memory)3.2.0 - "undefined method- it was due to the lack ofok?" in that other repo as wellskip_this_scenario.4.0.1-4.1 depend on
diff-lcs (< 1.4, >= 1.3, ~> 1.3), while we depend on= 1.4.45.2.0 only supports Ruby > 2.5. we support >=2.3. But it doesn't have a
diff-lcsversion conflict with its>= 1.4.4dependency.2.4 and 5.x+ are incompatible in terms of
cucumber.yml, the former expects--tag ~@wip, while the latter--tag 'not @wip'.I've checked 3.2.0, 4.0.0, 4.1.0, 5.3.0, 6.1.0, and they work (except for 4.1.0).
I vaguely recall we were discussing not runningcucumberon older Rubies (2.3-2.4), is this correct?Otherwise, I'll roll back to 3.2.0.✔️Sibling PRs: