Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Conversation

@pirj
Copy link
Member

@pirj pirj commented Dec 26, 2020

@pirj pirj self-assigned this Dec 26, 2020
@pirj pirj requested a review from JonRowe December 26, 2020 17:18
@pirj pirj force-pushed the conditionally-use-disable_monkey_patching branch 2 times, most recently from de8cd2f to aca027e Compare December 26, 2020 17:20
@pirj pirj force-pushed the conditionally-use-disable_monkey_patching branch from aca027e to 60b6214 Compare December 26, 2020 17:27
@JonRowe JonRowe merged commit a86200a into 4-0-dev Dec 26, 2020
@JonRowe JonRowe deleted the conditionally-use-disable_monkey_patching branch December 26, 2020 17:45
@JonRowe
Copy link
Member

JonRowe commented Dec 26, 2020

I assume your goal here is to get the rspec-core PR merged before the rspec-expectations one?

@pirj
Copy link
Member Author

pirj commented Dec 26, 2020

Yes, that was my plan to merge rspec-core first 😄
But now the order doesn't matter much - I hope they all to be green on their own. Let me quickly rebase and restart builds.

yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
…rspec/conditionally-use-disable_monkey_patching

Make specs inter-dependent, and backwards compatible'ish

---
This commit was imported from rspec/rspec-expectations@a86200a.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants