This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Remove support for legacy RSpec matchers (pre 3) #1253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
commented
Dec 24, 2020
| # should include clauses from methods defined using `chain`. | ||
| def include_chain_clauses_in_custom_matcher_descriptions? | ||
| @include_chain_clauses_in_custom_matcher_descriptions ||= false | ||
| @include_chain_clauses_in_custom_matcher_descriptions |
Member
Author
There was a problem hiding this comment.
||= true obviously doesn't work when false is assigned explicitly.
pirj
force-pushed
the
remove-monkey-patching
branch
2 times, most recently
from
b330730 to
2926bc9
Compare
Member
|
Some how the last change has messed up the history to include all the other changes? |
Member
Author
|
I've branched this PR off #1245, so this is as expected. History needs some commit juggling anyway. I want to spread the Changelog changes over commits. Also, the base PR was fixed up, so a rebase on it will be needed. Can't tell for sure, but I believe there might be some overlapping changes. Converted this to draft until #1245 is merged. |
pirj
force-pushed
the
remove-deprecations
branch
from
ddc7545 to
db4806c
Compare
pirj
force-pushed
the
remove-monkey-patching
branch
from
2926bc9 to
bbaef45
Compare
pirj
force-pushed
the
remove-deprecations
branch
from
db4806c to
d52d1f7
Compare
pirj
force-pushed
the
remove-monkey-patching
branch
from
bbaef45 to
6996e4f
Compare
pirj
force-pushed
the
remove-deprecations
branch
from
d52d1f7 to
fedb7ec
Compare
JonRowe
force-pushed
the
remove-monkey-patching
branch
3 times, most recently
from
1ab4671 to
e8e8bfc
Compare
As per http://rspec.info/blog/2013/07/the-plan-for-rspec-3/: > compatibility layer so that existing matchers will continue to work, with the plan to remove that compatibility layer in RSpec 4
pirj
force-pushed
the
remove-deprecations
branch
from
fedb7ec to
33f07d8
Compare
pirj
changed the title
pirj
changed the title
9 tasks
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
…rspec/remove-deprecations Remove support for legacy RSpec matchers (pre 3) --- This commit was imported from rspec/rspec-expectations@c167e5f.
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per http://rspec.info/blog/2013/07/the-plan-for-rspec-3/:
LegacyMacherAdapter(with typo)