Factorize common DynamicPredicate base.#1197
Conversation
pirj
left a comment
pirj
left a comment
There was a problem hiding this comment.
Looks good.
Travis is actually green (slow to report?)
marcandre
force-pushed
the
refactor_same_output
branch
from
07fdde0 to
6eebf29
Compare
Output is kept the same temporarily
marcandre
force-pushed
the
refactor_same_output
branch
from
6eebf29 to
c028a9a
Compare
|
Rebased, just to be sure. @JonRowe could this be merged please? Two subsequent PRs are waiting on this. |
JonRowe
left a comment
JonRowe
left a comment
There was a problem hiding this comment.
Sorry for the delay, after having had the time to finally give this a proper review, I have two questions.
| def predicate_method_name | ||
| predicate | ||
| end |
There was a problem hiding this comment.
I feel like this should be in the Has class as this implementation is only used there? (I've checked the other PR so I think thats the case?)
There was a problem hiding this comment.
Ah actually, I see, its not used elsewhere in has, ignore this comment. Commented on the wrong comment.
JonRowe
left a comment
JonRowe
left a comment
There was a problem hiding this comment.
Answered my own question and the remaining one is not a blocker.
3 participants
The
has_...andbe_...dynamic predicate matchers have a lot in common.This PR refactors both in terms of a common base class.
Output is kept the same temporarily
Precursor to #1195