Strict predicate #1196

marcandre · 2020-06-17T21:58:53Z

This PR adds a config setting strict_predicate_matchers which makes the checks for the dynamic predicate matchers strict. Default is false but for internal specs the setting is changed to true in spec_helper.

It changes the failure messages in the non-strict case from "expected ... to return true/false, ..." to "expected ... to be truthy/falsey, ...".

It builds on #1195

JonRowe · 2020-06-18T09:01:07Z

Converted to draft as it requires pre-requisite PRs to be approved/merged first.

marcandre · 2020-09-01T14:23:52Z

Rebased. CI errors are due to issues in the rspec-core gem, addressed in rspec/rspec-core#2756

pirj

Incredible! Thank you.

Changelog.md

lib/rspec/expectations/configuration.rb

features/built_in_matchers/predicates.feature

lib/rspec/matchers/built_in/has.rb

JonRowe

Mostly looks good, a few nitpicks / suggestions, including a bike shed which I apologise for but I'd rather obey the rubocop rules as they stand and change them later if people want to.

features/built_in_matchers/predicates.feature

lib/rspec/expectations/configuration.rb

JonRowe · 2020-09-02T18:53:41Z

lib/rspec/matchers/built_in/has.rb


-        def predicate_matches?
-          !!predicate_result
+        def predicate_matches?(value = true)


Can you remove the space around the = here, theres a rubocop rule enforcing no spaces, which I personally disagree with but its failing currently. (Ping @pirj, happy to change the rule but not in this PR).

This still needs fixing?

Oops, forgot to amend my commit. Done

marcandre · 2020-09-02T19:09:43Z

Should be all fixed.

JonRowe · 2020-09-03T10:20:21Z

lib/rspec/expectations/configuration.rb

        @on_potential_false_positives = behavior
      end

+


This extra blank line is failing rubocop.

Oh, I'm sorry about that. Fixed

JonRowe

Almost there, looks like the core build is fixed (on those Rubies that don't run Rubocop) but there is still a rubocop violation that needs fixing (sorry!)

…precise

marcandre · 2020-09-04T13:00:17Z

Thank you @JonRowe ❤️

pirj · 2020-09-04T13:05:48Z

Thank you, @marcandre !

JonRowe · 2020-09-04T13:41:18Z

Yes thank you @marcandre and thank you for your patience 😂

marcandre · 2020-09-04T16:50:50Z

Will it be possible to make a release?

JonRowe · 2020-09-15T19:53:22Z

I'm aiming to find some time this week to release 3.10 which would contain this.

marcandre · 2020-10-13T05:16:14Z

@JonRowe Any hope for a release?

JonRowe · 2020-10-24T15:34:21Z

A release was being prepared but is currently blocked by #1221, that needs a fix before a minor can be shipped.

JonRowe · 2020-10-30T14:35:07Z

Released as 3.10.0

marcandre · 2020-10-30T15:40:10Z

Awesome @JonRowe thanks for letting me know 🎉

See: - rspec/rspec-expectations#1195 - rspec/rspec-expectations#1196 - rspec/rspec-expectations#1277

* Remove outdated option rspec/rspec-core@0407831 * Use the non-globally exposed RSpec syntax rspec/rspec-core#2803 * Use the non-globally exposed RSpec syntax, cont rspec/rspec-core#2803 * Comply to strict predicate matchers See: - rspec/rspec-expectations#1195 - rspec/rspec-expectations#1196 - rspec/rspec-expectations#1277

marcandre force-pushed the strict_predicate branch 3 times, most recently from 57247ea to 750ed10 Compare June 17, 2020 22:35

JonRowe marked this pull request as draft June 18, 2020 09:00

marcandre force-pushed the strict_predicate branch from 750ed10 to b777f06 Compare June 18, 2020 13:48

JonRowe changed the base branch from master to main August 2, 2020 02:06

marcandre force-pushed the strict_predicate branch from b777f06 to e8bbfe1 Compare September 1, 2020 13:32

marcandre mentioned this pull request Sep 1, 2020

Fix predicates to return actual true/false values rspec/rspec-core#2756

Closed

marcandre marked this pull request as ready for review September 1, 2020 14:23

pirj approved these changes Sep 1, 2020

View reviewed changes

Changelog.md Outdated Show resolved Hide resolved

lib/rspec/expectations/configuration.rb Outdated Show resolved Hide resolved

features/built_in_matchers/predicates.feature Outdated Show resolved Hide resolved

lib/rspec/matchers/built_in/has.rb Show resolved Hide resolved

marcandre force-pushed the strict_predicate branch from e8bbfe1 to f6091b5 Compare September 1, 2020 20:20

JonRowe suggested changes Sep 2, 2020

View reviewed changes

marcandre force-pushed the strict_predicate branch from 2b069e4 to 9f23d77 Compare September 2, 2020 19:08

marcandre force-pushed the strict_predicate branch from 9f23d77 to 441fa94 Compare September 2, 2020 19:14

JonRowe reviewed Sep 3, 2020

View reviewed changes

JonRowe suggested changes Sep 3, 2020

View reviewed changes

Add setting for strict_predicate_matchers. Make failure message more …

693ce55

…precise

marcandre force-pushed the strict_predicate branch from 441fa94 to 693ce55 Compare September 3, 2020 23:24

JonRowe merged commit e7cab36 into rspec:main Sep 4, 2020

marcandre mentioned this pull request Oct 11, 2020

Add a shorthand for "TrueClass | FalseClass" ruby/rbs#133

Closed

marcandre deleted the strict_predicate branch October 13, 2020 05:13

pirj mentioned this pull request May 6, 2021

Provide both strict (true/false) and loose (truthy/falsey) forms of the be/have matchers rspec/rspec#147

Open

kachick mentioned this pull request Jun 6, 2021

rspec の strict_predicate_matchers include_chain_clauses_in_custom_matcher_descriptions on_potential_false_positivesとかってみんな知ってた・・・？ kachick/times_kachick#104

Closed

This was referenced Jul 18, 2021

Turn strict_predicate_matchers on by default #1277

Merged

Add deprecation warnings for features to be removed/changed in RSpec 4 #1301

Closed

pirj added a commit to pirj/discourse that referenced this pull request Jul 25, 2022

Comply to strict predicate matchers

586f10a

See: - rspec/rspec-expectations#1195 - rspec/rspec-expectations#1196 - rspec/rspec-expectations#1277

pirj mentioned this pull request Jul 25, 2022

Add RSpec 4 compatibility discourse/discourse#17652

Merged

pirj added a commit to pirj/discourse that referenced this pull request Jul 27, 2022

Comply to strict predicate matchers

d5443c1

See: - rspec/rspec-expectations#1195 - rspec/rspec-expectations#1196 - rspec/rspec-expectations#1277

pirj mentioned this pull request Sep 27, 2025

[rspec-expectations] RSpec 4 deprecation warnings rspec/rspec#124

Closed

11 tasks

Uh oh!

Strict predicate #1196

Strict predicate #1196

Uh oh!

Conversation

marcandre commented Jun 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonRowe commented Jun 18, 2020

Uh oh!

marcandre commented Sep 1, 2020

Uh oh!

pirj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JonRowe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JonRowe Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

JonRowe Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

marcandre Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

marcandre commented Sep 2, 2020

Uh oh!

JonRowe Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

marcandre Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

JonRowe left a comment

Choose a reason for hiding this comment

Uh oh!

marcandre commented Sep 4, 2020

Uh oh!

pirj commented Sep 4, 2020

Uh oh!

JonRowe commented Sep 4, 2020

Uh oh!

marcandre commented Sep 4, 2020

Uh oh!

JonRowe commented Sep 15, 2020

Uh oh!

marcandre commented Oct 13, 2020

Uh oh!

JonRowe commented Oct 24, 2020

Uh oh!

JonRowe commented Oct 30, 2020

Uh oh!

marcandre commented Oct 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marcandre commented Jun 17, 2020 •

edited

Loading